From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: rohan.g.thomas@altera.com
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Rohan G Thomas <rohan.g.thomas@intel.com>,
Boon Khai Ng <boon.khai.ng@altera.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Matthew Gerlach <matthew.gerlach@altera.com>
Subject: Re: [PATCH net v3 2/3] net: stmmac: Consider Tx VLAN offload tag length for maxSDU
Date: Fri, 17 Oct 2025 13:44:32 +0100 [thread overview]
Message-ID: <aPI6MEVp9WBR3nRo@shell.armlinux.org.uk> (raw)
In-Reply-To: <20251017-qbv-fixes-v3-2-d3a42e32646a@altera.com>
On Fri, Oct 17, 2025 at 02:11:20PM +0800, Rohan G Thomas via B4 Relay wrote:
> From: Rohan G Thomas <rohan.g.thomas@altera.com>
>
> On hardware with Tx VLAN offload enabled, add the VLAN tag length to
> the skb length before checking the Qbv maxSDU if Tx VLAN offload is
> requested for the packet. Add 4 bytes for 802.1Q tag.
This needs to say _why_. Please describe the problem that the current
code suffers from. (e.g. the packet becomes too long for the queue to
handle, which causes it to be dropped - which is my guess.)
We shouldn't be guessing the reasons behind changes.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-10-17 12:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 6:11 [PATCH net v3 0/3] net: stmmac: Fixes for stmmac Tx VLAN insert and EST Rohan G Thomas
2025-10-17 6:11 ` Rohan G Thomas via B4 Relay
2025-10-17 6:11 ` [PATCH net v3 1/3] net: stmmac: vlan: Disable 802.1AD tag insertion offload Rohan G Thomas
2025-10-17 6:11 ` Rohan G Thomas via B4 Relay
2025-10-17 12:42 ` Russell King (Oracle)
2025-10-18 1:56 ` G Thomas, Rohan
2025-10-23 3:31 ` G Thomas, Rohan
2025-10-23 10:54 ` Russell King (Oracle)
2025-10-24 3:03 ` G Thomas, Rohan
2025-10-17 6:11 ` [PATCH net v3 2/3] net: stmmac: Consider Tx VLAN offload tag length for maxSDU Rohan G Thomas
2025-10-17 6:11 ` Rohan G Thomas via B4 Relay
2025-10-17 7:36 ` G Thomas, Rohan
2025-10-17 12:21 ` Vadim Fedorenko
2025-10-18 1:50 ` G Thomas, Rohan
2025-10-23 10:59 ` Russell King (Oracle)
2025-10-23 16:03 ` G Thomas, Rohan
2025-10-17 12:44 ` Russell King (Oracle) [this message]
2025-10-18 2:06 ` G Thomas, Rohan
2025-10-23 10:58 ` Russell King (Oracle)
2025-10-17 17:16 ` kernel test robot
2025-10-27 9:03 ` G Thomas, Rohan
2025-10-17 6:11 ` [PATCH net v3 3/3] net: stmmac: est: Fix GCL bounds checks Rohan G Thomas
2025-10-17 6:11 ` Rohan G Thomas via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPI6MEVp9WBR3nRo@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=boon.khai.ng@altera.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthew.gerlach@altera.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rohan.g.thomas@altera.com \
--cc=rohan.g.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.