From: Simon Horman <horms@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
davem@davemloft.net, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Mathew McBride <matt@traverse.com.au>
Subject: Re: [PATCH net] dpaa2-eth: fix the pointer passed to PTR_ALIGN on Tx path
Date: Fri, 17 Oct 2025 10:03:59 +0100 [thread overview]
Message-ID: <aPIGf4aY6cbIa2AP@horms.kernel.org> (raw)
In-Reply-To: <20251016135807.360978-1-ioana.ciornei@nxp.com>
On Thu, Oct 16, 2025 at 04:58:07PM +0300, Ioana Ciornei wrote:
> The blamed commit increased the needed headroom to account for
> alignment. This means that the size required to always align a Tx buffer
> was added inside the dpaa2_eth_needed_headroom() function. By doing
> that, a manual adjustment of the pointer passed to PTR_ALIGN() was no
> longer correct since the 'buffer_start' variable was already pointing
> to the start of the skb's memory.
>
> The behavior of the dpaa2-eth driver without this patch was to drop
> frames on Tx even when the headroom was matching the 128 bytes
> necessary. Fix this by removing the manual adjust of 'buffer_start' from
> the PTR_MODE call.
>
> Closes: https://lore.kernel.org/netdev/70f0dcd9-1906-4d13-82df-7bbbbe7194c6@app.fastmail.com/T/#u
> Fixes: f422abe3f23d ("dpaa2-eth: increase the needed headroom to account for alignment")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> Tested-by: Mathew McBride <matt@traverse.com.au>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-10-17 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 13:58 [PATCH net] dpaa2-eth: fix the pointer passed to PTR_ALIGN on Tx path Ioana Ciornei
2025-10-17 9:03 ` Simon Horman [this message]
2025-10-18 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPIGf4aY6cbIa2AP@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@traverse.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.