From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>
Subject: Re: [PATCH for-4.21 01/10] x86/HPET: limit channel changes
Date: Fri, 17 Oct 2025 11:23:54 +0200 [thread overview]
Message-ID: <aPILKoTwmUYK5p8H@Mac.lan> (raw)
In-Reply-To: <494c897c-a138-4d16-93b2-67e3aa8d41e7@suse.com>
On Thu, Oct 16, 2025 at 09:31:21AM +0200, Jan Beulich wrote:
> Despite 1db7829e5657 ("x86/hpet: do local APIC EOI after interrupt
> processing") we can still observe nested invocations of
> hpet_interrupt_handler(). This is, afaict, a result of previously used
> channels retaining their IRQ affinity until some other CPU re-uses them.
> Such nesting is increasingly problematic with higher CPU counts, as both
> handle_hpet_broadcast() and cpumask_raise_softirq() have a cpumask_t local
> variable. IOW already a single level of nesting may require more stack
> space (2 times above 4k) than we have available (8k), when NR_CPUS=16383
> (the maximum value presently possible).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Whether this is still worthwhile with "x86/HPET: use single, global, low-
> priority vector for broadcast IRQ" isn't quite clear to me.
Seeing the rest of the series, I don't think this is necessary
anymore? Also the comment you here is made stale by the patch that
uses a global vector.
Thanks, Roger.
next prev parent reply other threads:[~2025-10-17 9:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 7:30 [PATCH for-4.21 00/10] x86/HPET: broadcast IRQ and other improvements Jan Beulich
2025-10-16 7:31 ` [PATCH for-4.21 01/10] x86/HPET: limit channel changes Jan Beulich
2025-10-16 10:24 ` Roger Pau Monné
2025-10-16 11:47 ` Jan Beulich
2025-10-16 15:07 ` Roger Pau Monné
2025-10-16 15:16 ` Jan Beulich
2025-10-16 15:25 ` Roger Pau Monné
2025-10-17 9:23 ` Roger Pau Monné [this message]
2025-10-17 9:55 ` Jan Beulich
2025-10-16 7:31 ` [PATCH for-4.21 02/10] x86/HPET: disable unused channels Jan Beulich
2025-10-16 11:42 ` Roger Pau Monné
2025-10-16 11:57 ` Jan Beulich
2025-10-16 15:34 ` Roger Pau Monné
2025-10-16 15:55 ` Jan Beulich
2025-10-16 16:28 ` Roger Pau Monné
2025-10-16 16:31 ` Roger Pau Monné
2025-10-17 6:08 ` Jan Beulich
2025-10-17 6:10 ` Jan Beulich
2025-10-16 7:32 ` [PATCH for-4.21 03/10] x86/HPET: use single, global, low-priority vector for broadcast IRQ Jan Beulich
2025-10-16 16:27 ` Roger Pau Monné
2025-10-17 7:15 ` Jan Beulich
2025-10-17 8:20 ` Roger Pau Monné
2025-10-20 5:53 ` Jan Beulich
2025-10-20 15:49 ` Roger Pau Monné
2025-10-20 16:05 ` Jan Beulich
2025-10-21 8:37 ` Roger Pau Monné
2025-10-16 17:01 ` Andrew Cooper
2025-10-17 6:23 ` Jan Beulich
2025-10-16 7:32 ` [PATCH for-4.21 04/10] x86/HPET: ignore "stale" IRQs Jan Beulich
2025-10-17 9:19 ` Roger Pau Monné
2025-10-17 9:57 ` Jan Beulich
2025-10-17 12:13 ` Roger Pau Monné
2025-10-16 7:32 ` [PATCH 05/10] x86/HPET: avoid indirect call to event handler Jan Beulich
2025-10-16 7:33 ` [PATCH 06/10] x86/HPET: make another channel flags update atomic Jan Beulich
2025-10-16 7:33 ` [PATCH 07/10] x86/HPET: move legacy tick IRQ count adjustment Jan Beulich
2025-10-16 7:34 ` [PATCH 08/10] x86/HPET: shrink IRQ-descriptor locked region in set_channel_irq_affinity() Jan Beulich
2025-10-16 7:34 ` [PATCH 09/10] x86/HPET: reduce hpet_next_event() call sites Jan Beulich
2025-10-16 7:35 ` [PATCH 10/10] x86/HPET: don't use hardcoded 0 for "long timeout" Jan Beulich
2025-10-16 10:05 ` [PATCH for-4.21 00/10] x86/HPET: broadcast IRQ and other improvements Roger Pau Monné
2025-10-16 10:41 ` Jan Beulich
2025-10-17 16:03 ` Oleksii Kurochko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPILKoTwmUYK5p8H@Mac.lan \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=oleksii.kurochko@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.