All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Dykstra <dwd@cern.ch>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-ext4@vger.kernel.org,
	Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Subject: Re: [PATCH] fuse2fs: open read-only when ro option and image non-writable
Date: Fri, 17 Oct 2025 15:48:32 -0500	[thread overview]
Message-ID: <aPKroGbrXvuoBZUl@cern.ch> (raw)
In-Reply-To: <aPKjtQz5lmUcWf5O@cern.ch>

On Fri, Oct 17, 2025 at 03:14:50PM -0500, Dave Dykstra wrote:
> On Fri, Oct 17, 2025 at 12:24:56PM -0700, Darrick J. Wong wrote:
...
> > > +	ret = 4;
> > 
> > Why 4?  Is this an internal mount bug?
> 
> I was just guessing; I didn't know what the bits meant.  Where are they
> documented?  All I knew was that it needed to not include the "& 1" bit
> which was included with "ret = 3" because that printed an erroneous
> error just after the "out" label.

Oh, it's supposed to follow the return codes from mount(8).  I think
ret = 2 is most appropriate then.

Dave


  reply	other threads:[~2025-10-17 20:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16 20:02 [PATCH] fuse2fs: open read-only when ro option and image non-writable Dave Dykstra
2025-10-17 19:24 ` Darrick J. Wong
2025-10-17 20:14   ` Dave Dykstra
2025-10-17 20:48     ` Dave Dykstra [this message]
2025-10-17 21:16       ` Dave Dykstra
2025-10-17 23:28       ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPKroGbrXvuoBZUl@cern.ch \
    --to=dwd@cern.ch \
    --cc=2129743+DrDaveD@users.noreply.github.com \
    --cc=djwong@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.