From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jinhui Guo <guojinhui.liam@bytedance.com>
Cc: mika.westerberg@linux.intel.com, jsd@semihalf.com,
andi.shyti@kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] i2c: designware: Disable SMBus interrupts to prevent storms from mis-configured firmware
Date: Sat, 18 Oct 2025 22:22:21 +0300 [thread overview]
Message-ID: <aPPo7VWm4HyoHSIE@ashevche-desk.local> (raw)
On Sat, Oct 11, 2025 at 03:30:57PM +0800, Jinhui Guo wrote:
> When probing the I2C master, disable SMBus interrupts to prevent
> storms caused by broken firmware mis-configuring IC_SMBUS=1; the
> handler never services them and a mis-configured SMBUS Master
> extend-clock timeout can flood the CPU.
...
> #define DW_IC_TX_ABRT_SOURCE 0x80
> #define DW_IC_ENABLE_STATUS 0x9c
> #define DW_IC_CLR_RESTART_DET 0xa8
> +#define DW_IC_SMBUS_INTR_MASK 0xcc
It seems one TAB too little.
> #define DW_IC_COMP_PARAM_1 0xf4
> #define DW_IC_COMP_VERSION 0xf8
> #define DW_IC_SDA_HOLD_MIN_VERS 0x3131312A /* "111*" == v1.11* */
...
The rest LGTM, but let Mika to review.
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next reply other threads:[~2025-10-18 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 19:22 Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-11 7:30 [PATCH 0/1] i2c: designware: Fix SMBUS Master interrupts storms Jinhui Guo
2025-10-11 7:30 ` [PATCH 1/1] i2c: designware: Disable SMBus interrupts to prevent storms from mis-configured firmware Jinhui Guo
2025-10-14 7:15 ` Andy Shevchenko
2025-10-20 10:29 ` Mika Westerberg
2025-10-21 7:46 ` Jinhui Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPPo7VWm4HyoHSIE@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=guojinhui.liam@bytedance.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.