All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org,
	jirislaby@kernel.org, Gerhard Engleder <eg@keba.com>
Subject: Re: [PATCH v2 1/2] serial: Keep rs485 settings for devices without firmware node
Date: Sun, 19 Oct 2025 19:20:36 +0200	[thread overview]
Message-ID: <aPUd5NXmmow77WF7@wunner.de> (raw)
In-Reply-To: <4e3da3b9-693e-4d21-901e-14ac4663d340@engleder-embedded.com>

On Sun, Oct 19, 2025 at 05:21:30PM +0200, Gerhard Engleder wrote:
> On 19.10.25 16:42, Lukas Wunner wrote:
> > BTW is there a good reason that you don't have a fwnode for your UART?
> > It seems odd to have a UART but not describe it in the devicetree.
> > Maybe that's the real problem and fixing it obviates the need for this
> > patch?
> 
> This auxiliary device is part of a FPGA based PCIe device. It is mostly
> used on x86 but arm64 is also possible in the future. There is no device
> tree or ACPI information available for this device. Think about an x86
> CPU module where you cannot influence the BIOS implementation and device
> tree is not available. IMO having a self describing PCIe device which
> works out of the box is best in this case.

In case you're not aware of it, it's possible to assign a software
fwnode to devices through device_add_software_node().  There is
precedent for its usage among 8250 drivers, see 8250_bcm2835aux.c
and 8250_exar.c.

So that would be an alternative to this patch.  Conceivably, your
FPGA might support different UART types and each might default to
different rs485 settings.  A software node as used by 8250_bcm2835aux.c
would allow you to define those settings through the driver_data.

Thanks,

Lukas

  parent reply	other threads:[~2025-10-19 17:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17 14:42 [PATCH v2 0/2] serial: add KEBA UART driver Gerhard Engleder
2025-10-17 14:42 ` [PATCH v2 1/2] serial: Keep rs485 settings for devices without firmware node Gerhard Engleder
2025-10-19  8:50   ` Lukas Wunner
2025-10-19 14:10     ` Gerhard Engleder
2025-10-19 14:42       ` Lukas Wunner
2025-10-19 15:21         ` Gerhard Engleder
2025-10-19 17:02           ` Lukas Wunner
2025-10-19 19:06             ` Gerhard Engleder
2025-10-19 17:20           ` Lukas Wunner [this message]
2025-10-19 19:19             ` Gerhard Engleder
2025-10-17 14:42 ` [PATCH v2 2/2] serial: 8250: add driver for KEBA UART Gerhard Engleder
2025-11-27 16:05 ` [PATCH v2 0/2] serial: add KEBA UART driver Andy Shevchenko
2025-11-27 19:26   ` Gerhard Engleder
2025-11-27 19:56     ` Andy Shevchenko
2025-11-27 20:07       ` Gerhard Engleder
2025-11-27 20:56         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPUd5NXmmow77WF7@wunner.de \
    --to=lukas@wunner.de \
    --cc=eg@keba.com \
    --cc=gerhard@engleder-embedded.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.