All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo2@yeah.net>
To: Andreas Kemnade <akemnade@kernel.org>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alistair Francis <alistair@alistair23.me>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.li@nxp.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v3 3/3] ARM: dts: imx: e70k02: add sy7636
Date: Mon, 20 Oct 2025 20:48:00 +0800	[thread overview]
Message-ID: <aPYvgKWNvr0RxOKQ@dragon> (raw)
In-Reply-To: <20250917-sy7636-rsrc-v3-3-331237d507a2@kernel.org>

On Wed, Sep 17, 2025 at 09:14:31AM +0200, Andreas Kemnade wrote:
> Add the EPD PMIC for the e70k02 based devices as a step towards full EPD
> support.
> 
> Acked-by: Alistair Francis <alistair@alistair23.me>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Andreas Kemnade <akemnade@kernel.org>
> ---
>  arch/arm/boot/dts/nxp/imx/e70k02.dtsi              | 25 +++++++++++++++++++++-
>  .../arm/boot/dts/nxp/imx/imx6sl-tolino-vision5.dts | 24 +++++++++++++++++++++
>  .../arm/boot/dts/nxp/imx/imx6sll-kobo-librah2o.dts | 24 +++++++++++++++++++++
>  3 files changed, 72 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/e70k02.dtsi b/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
> index dcc3c9d488a88..b4f42f71c6c49 100644
> --- a/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
> @@ -69,6 +69,14 @@ memory@80000000 {
>  		reg = <0x80000000 0x20000000>;
>  	};
>  
> +	epd_pmic_supply: regulator-epd-pmic-in {
> +		compatible = "regulator-fixed";
> +		regulator-name = "epd_pmic_supply";
> +		gpio = <&gpio2 14 GPIO_ACTIVE_HIGH>;
> +		startup-delay-us = <20000>;
> +		enable-active-high;

enable-active-high right after gpio = <... GPIO_ACTIVE_HIGH>, as it's a
supplement description for "gpio" property.

Shawn

> +	};
> +
>  	reg_wifi: regulator-wifi {
>  		compatible = "regulator-fixed";
>  		regulator-name = "SD3_SPWR";
> @@ -133,7 +141,22 @@ touchscreen@24 {
>  		vdd-supply = <&ldo5_reg>;
>  	};
>  
> -	/* TODO: SY7636 PMIC for E Ink at 0x62 */
> +	sy7636: pmic@62 {
> +		compatible = "silergy,sy7636a";
> +		reg = <0x62>;
> +		enable-gpios = <&gpio2 8 GPIO_ACTIVE_HIGH>;
> +		vcom-en-gpios = <&gpio2 3 GPIO_ACTIVE_HIGH>;
> +		epd-pwr-good-gpios = <&gpio2 13 GPIO_ACTIVE_HIGH>;
> +		vin-supply = <&epd_pmic_supply>;
> +
> +		#thermal-sensor-cells = <0>;
> +
> +		regulators {
> +			reg_epdpmic: vcom {
> +				regulator-name = "vcom";
> +			};
> +		};
> +	};
>  
>  };
>  
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-vision5.dts b/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-vision5.dts
> index a2534c422a522..f8709a9524093 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-vision5.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-vision5.dts
> @@ -26,6 +26,11 @@ / {
>  	compatible = "kobo,tolino-vision5", "fsl,imx6sl";
>  };
>  
> +&epd_pmic_supply {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_epd_pmic_supply>;
> +};
> +
>  &gpio_keys {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_gpio_keys>;
> @@ -59,6 +64,12 @@ MX6SL_PAD_FEC_RXD1__GPIO4_IO18          0x10059 /* TP_RST */
>  		>;
>  	};
>  
> +	pinctrl_epd_pmic_supply: epd-pmic-supplygrp {
> +		fsl,pins = <
> +			MX6SL_PAD_EPDC_PWRWAKEUP__GPIO2_IO14    0x40010059
> +		>;
> +	};
> +
>  	pinctrl_gpio_keys: gpio-keysgrp {
>  		fsl,pins = <
>  			MX6SL_PAD_FEC_CRS_DV__GPIO4_IO25	0x17059	/* PWR_SW */
> @@ -159,6 +170,14 @@ MX6SL_PAD_KEY_COL2__GPIO3_IO28		0x1b8b1 /* ricoh619 bat_low_int */
>  		>;
>  	};
>  
> +	pinctrl_sy7636_gpio: sy7636-gpiogrp {
> +		fsl,pins = <
> +			MX6SL_PAD_EPDC_VCOM0__GPIO2_IO03        0x40010059 /* VCOM_CTRL */
> +			MX6SL_PAD_EPDC_PWRCTRL1__GPIO2_IO08     0x40010059 /* EN */
> +			MX6SL_PAD_EPDC_PWRSTAT__GPIO2_IO13      0x17059 /* PWR_GOOD */
> +		>;
> +	};
> +
>  	pinctrl_uart1: uart1grp {
>  		fsl,pins = <
>  			MX6SL_PAD_UART1_TXD__UART1_TX_DATA 0x1b0b1
> @@ -329,6 +348,11 @@ &ricoh619 {
>  	pinctrl-0 = <&pinctrl_ricoh_gpio>;
>  };
>  
> +&sy7636 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_sy7636_gpio>;
> +};
> +
>  &uart1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_uart1>;
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-librah2o.dts b/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-librah2o.dts
> index 660620d226f71..19bbe60331b36 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-librah2o.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-librah2o.dts
> @@ -36,6 +36,11 @@ &cpu0 {
>  	soc-supply = <&dcdc1_reg>;
>  };
>  
> +&epd_pmic_supply {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_epd_pmic_supply>;
> +};
> +
>  &gpio_keys {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_gpio_keys>;
> @@ -69,6 +74,12 @@ MX6SLL_PAD_GPIO4_IO18__GPIO4_IO18	0x10059 /* TP_RST */
>  		>;
>  	};
>  
> +	pinctrl_epd_pmic_supply: epd-pmic-supplygrp {
> +		fsl,pins = <
> +			MX6SLL_PAD_EPDC_PWR_WAKE__GPIO2_IO14    0x40010059
> +		>;
> +	};
> +
>  	pinctrl_gpio_keys: gpio-keysgrp {
>  		fsl,pins = <
>  			MX6SLL_PAD_GPIO4_IO25__GPIO4_IO25	0x17059	/* PWR_SW */
> @@ -169,6 +180,14 @@ MX6SLL_PAD_KEY_COL2__GPIO3_IO28		0x1b8b1 /* ricoh619 bat_low_int */
>  		>;
>  	};
>  
> +	pinctrl_sy7636_gpio: sy7636-gpiogrp {
> +		fsl,pins = <
> +			MX6SLL_PAD_EPDC_VCOM0__GPIO2_IO03       0x40010059 /* VCOM_CTRL */
> +			MX6SLL_PAD_EPDC_PWR_CTRL1__GPIO2_IO08   0x40010059 /* EN */
> +			MX6SLL_PAD_EPDC_PWR_STAT__GPIO2_IO13    0x17059 /* PWR_GOOD */
> +		>;
> +	};
> +
>  	pinctrl_uart1: uart1grp {
>  		fsl,pins = <
>  			MX6SLL_PAD_UART1_TXD__UART1_DCE_TX 0x1b0b1
> @@ -319,6 +338,11 @@ &ricoh619 {
>  	pinctrl-0 = <&pinctrl_ricoh_gpio>;
>  };
>  
> +&sy7636 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_sy7636_gpio>;
> +};
> +
>  &uart1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_uart1>;
> 
> -- 
> 2.47.3
> 


  reply	other threads:[~2025-10-20 12:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17  7:14 [PATCH v3 0/3] regulator: sy7636a: define and init all resources needed Andreas Kemnade
2025-09-17  7:14 ` [PATCH v3 1/3] dt-bindings: mfd: sy7636a: Add missing gpio pins and supply Andreas Kemnade
2025-10-08 15:31   ` (subset) " Lee Jones
2025-10-20 13:15     ` Andreas Kemnade
2025-10-21 10:46       ` Lee Jones
2025-09-17  7:14 ` [PATCH v3 2/3] regulator: sy7636a: add gpios and input regulator Andreas Kemnade
2025-09-17  7:14 ` [PATCH v3 3/3] ARM: dts: imx: e70k02: add sy7636 Andreas Kemnade
2025-10-20 12:48   ` Shawn Guo [this message]
2025-10-17 11:24 ` (subset) [PATCH v3 0/3] regulator: sy7636a: define and init all resources needed Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPYvgKWNvr0RxOKQ@dragon \
    --to=shawnguo2@yeah.net \
    --cc=Frank.li@nxp.com \
    --cc=akemnade@kernel.org \
    --cc=alistair@alistair23.me \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.