All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin Foster <colin.foster@in-advantage.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	romain.gantois@bootlin.com,
	Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 05/11] package/python-tftpy: add host variant
Date: Mon, 20 Oct 2025 10:18:32 -0500	[thread overview]
Message-ID: <aPZSyAGH2sGhoRwA@colin-ia-desktop> (raw)
In-Reply-To: <20251018194314.114284-6-thomas.petazzoni@bootlin.com>

On Sat, Oct 18, 2025 at 09:43:03PM +0200, Thomas Petazzoni wrote:
> A host variant of python-tftpy will be needed for Snagboot, so enable
> it, and add a very simple test for the host package. We considered
> adding a test that actually starts a TFTP server with tftpy and then
> downloads from that server with the client-side of tftpy, but
> allocating an available UDP port reliably is tricky, so we kept the
> test case very simple for now.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Looks good to me. For what its worth:

Reviewed-by: Colin Foster <colin.foster@in-advantage.com>

The tftpy package is a little out of date. There were some issues with
packaging / setuptools. I don't think it should make a difference to
Buildroot, but I've been letting the dust settle either way. I can send
a patch to the latest (0.8.6) if that's desired.

Colin

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-10-20 15:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-18 19:42 [Buildroot] [PATCH 00/11] Add support for building Snagboot Thomas Petazzoni via buildroot
2025-10-18 19:42 ` [Buildroot] [PATCH 01/11] support/testing/infra: improve run_cmd_on_host() to show stdout/stderr Thomas Petazzoni via buildroot
2025-10-30 21:03   ` Julien Olivain via buildroot
2025-11-17 19:56   ` Arnout Vandecappelle via buildroot
2025-10-18 19:43 ` [Buildroot] [PATCH 02/11] support/testing/infra/basetest.py: add BRHostPkgTest class Thomas Petazzoni via buildroot
2025-10-18 19:43 ` [Buildroot] [PATCH 03/11] package/python-crccheck: new package Thomas Petazzoni via buildroot
2025-10-18 19:43 ` [Buildroot] [PATCH 04/11] support/testing/tests/package/test_python_serial.py: new test case Thomas Petazzoni via buildroot
2025-10-18 19:43 ` [Buildroot] [PATCH 05/11] package/python-tftpy: add host variant Thomas Petazzoni via buildroot
2025-10-20 15:18   ` Colin Foster [this message]
2025-10-18 19:43 ` [Buildroot] [PATCH 06/11] package/python-pyusb: enable " Thomas Petazzoni via buildroot
2025-10-18 19:43 ` [Buildroot] [PATCH 07/11] package/python-xmodem: add " Thomas Petazzoni via buildroot
2025-10-18 19:43 ` [Buildroot] [PATCH 08/11] package/python-appdirs: " Thomas Petazzoni via buildroot
2025-10-18 19:43 ` [Buildroot] [PATCH 09/11] package/python-fs: new package Thomas Petazzoni via buildroot
2025-10-18 19:43 ` [Buildroot] [PATCH 10/11] package/python-pyfatfs: " Thomas Petazzoni via buildroot
2025-10-18 19:43 ` [Buildroot] [PATCH 11/11] package/snagboot: " Thomas Petazzoni via buildroot
2025-10-20  7:17   ` Romain Gantois via buildroot
2025-10-20  7:54     ` Thomas Petazzoni via buildroot
2025-10-29  8:13       ` Romain Gantois via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPZSyAGH2sGhoRwA@colin-ia-desktop \
    --to=colin.foster@in-advantage.com \
    --cc=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    --cc=romain.gantois@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.