Re: [PATCH] drm/amd: Add missing return for VPE idle handler

[Sultan Alsawaf <sultan@kerneltoast.com>]

On Mon, Oct 20, 2025 at 05:34:34PM -0500, Mario Limonciello wrote:
> Adjusting the idle handler for DPM0 handling forgot a return statement
> which causes the system to not be able to enter s0i3.
> 
> Add the missing return statement.
> 
> Cc: stable@vger.kernel.org
> Reported-by: Sultan Alsawaf <sultan@kerneltoast.com>
> Closes: https://lore.kernel.org/amd-gfx/aPawCXBY9eM8oZvG@sultan-box/

I just noticed that this link doesn't work; it seems like that email of mine
didn't make it onto the amd-gfx list?

> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
> index f4932339d79d..aa78c2ee9e21 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
> @@ -356,6 +356,7 @@ static void vpe_idle_work_handler(struct work_struct *work)
>  		goto reschedule;
>  
>  	amdgpu_device_ip_set_powergating_state(adev, AMD_IP_BLOCK_TYPE_VPE, AMD_PG_STATE_GATE);
> +	return;
>  
>  reschedule:
>  	schedule_delayed_work(&adev->vpe.idle_work, VPE_IDLE_TIMEOUT);
> -- 
> 2.49.0
> 

Sultan