Re: [LTP] [PATCH v4 1/3] lib: Add support option for .needs_cmds

[Wei Gao via ltp <ltp@lists.linux.it>]

On Mon, Oct 20, 2025 at 03:33:29PM +0200, Petr Vorel wrote:
> Hi Wei,
> 
> ...
> > +++ b/lib/tst_cmd.c
> > @@ -265,7 +265,12 @@ int tst_check_cmd(const char *cmd, const int brk_nosupp)
> >  	str = strtok_r(NULL, " ", &next);
> 
> >  	if (tst_get_path(cmd_token, path, sizeof(path)))
> > -		tst_brkm(TCONF, NULL, "Couldn't find '%s' in $PATH", cmd_token);
> > +		if (brk_nosupp) {
> > +			tst_brkm(TCONF, NULL, "Couldn't find '%s' in $PATH", cmd_token);
> > +		} else {
> > +			tst_resm(TCONF, "Couldn't find '%s' in $PATH", cmd_token);
> > +			return 1;
> > +		}
> 
> You ask me how you could split changes to be compilable and yet not in a single
> commit.  This is a completely unrelated change, it should be in a separate
> commit, with:
> 
> Fixes: 257394e4e3 ("Filter mkfs version in tst_fs")
Thanks, will use separte commit next patch.
> 
> Kind regards,
> Petr
> 
> >  	if (!op_token)
> >  		return 0;

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp