From: Mike Rapoport <rppt@kernel.org>
To: Harry Yoo <harry.yoo@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org
Subject: Re: [PATCH V1 2/2] treewide: include linux/pgalloc.h instead of asm/pgalloc.h
Date: Tue, 21 Oct 2025 09:07:55 +0300 [thread overview]
Message-ID: <aPcjO6pCHZCZiRZ1@kernel.org> (raw)
In-Reply-To: <aPcVlz2Auk4JK2ds@hyeyoo>
On Tue, Oct 21, 2025 at 02:09:43PM +0900, Harry Yoo wrote:
> On Mon, Oct 20, 2025 at 05:44:08PM +0300, Mike Rapoport wrote:
> > > diff --git a/mm/pt_reclaim.c b/mm/pt_reclaim.c
> > > index 7e9455a18aae..ec6fe4eb2644 100644
> > > --- a/mm/pt_reclaim.c
> > > +++ b/mm/pt_reclaim.c
> > > @@ -1,7 +1,7 @@
> > > // SPDX-License-Identifier: GPL-2.0
> > > #include <linux/hugetlb.h>
> > > #include <asm-generic/tlb.h>
> > > -#include <asm/pgalloc.h>
> > > +#include <linux/pgalloc.h>
> >
> > Please move it before include <asm-generic/tlb.h>
>
> Will do, and in this case no empty line between #include <asm*/*.h> and
> #include <linux/*.h>, right?
Won't hurt :)
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2025-10-21 6:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-19 7:25 [PATCH V1 0/2] mm: MISC follow-up patches for linux/pgalloc.h Harry Yoo
2025-10-19 7:25 ` [PATCH V1 1/2] MAINTAINERS: add include/linux/pgalloc.h to MM CORE section Harry Yoo
2025-10-19 22:07 ` SeongJae Park
2025-10-20 7:43 ` Harry Yoo
2025-10-20 13:38 ` David Hildenbrand
2025-10-20 13:51 ` Harry Yoo
2025-10-20 14:07 ` David Hildenbrand
2025-10-20 14:05 ` Lorenzo Stoakes
2025-10-20 14:10 ` Harry Yoo
2025-10-20 14:34 ` Mike Rapoport
2025-10-19 7:25 ` [PATCH V1 2/2] treewide: include linux/pgalloc.h instead of asm/pgalloc.h Harry Yoo
2025-10-20 13:39 ` David Hildenbrand
2025-10-20 14:12 ` Lorenzo Stoakes
2025-10-20 14:44 ` Mike Rapoport
2025-10-21 5:09 ` Harry Yoo
2025-10-21 6:07 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPcjO6pCHZCZiRZ1@kernel.org \
--to=rppt@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=harry.yoo@oracle.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.