All of lore.kernel.org
 help / color / mirror / Atom feed
From: ShiHao <i.shihao.999@gmail.com>
To: Simon Horman <horms@kernel.org>
Cc: --cc=andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@google.com, i.shihao.999@gmail.com, kuba@kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH  net-next v2]: 3c515: replace cleanup_module with __exit
Date: Tue, 21 Oct 2025 11:37:59 +0530	[thread overview]
Message-ID: <aPcjP24rdKSLmM5g@fedora> (raw)
In-Reply-To: <aPYxbwjIlyPHrTY3@horms.kernel.org>

> Thanks for the update.
> The code changes in this version look good to me.
> 
> One minor nit: the whitespace in the subject look slightly off.
> There is probably no need to repost because of this.
> But I would have gone for:
> 
> Subject: [PATCH net-next v2] 3c515: replace cleanup_module with __exit
> 
> But overall this looks good to me.
> 
> Reviewed-by: Simon Horman <horms@kernel.org>

Thanks, Simon

I’ll make sure correct  whitespace formatting next time.  
Appreciate the review. Thanks for your time.

Best regards,
Shi Hao

  reply	other threads:[~2025-10-21  6:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-18  5:25 [PATCH net-next v2]: 3c515 : replace cleanup_module with __exit Shi Hao
2025-10-20 12:56 ` Simon Horman
2025-10-21  6:07   ` ShiHao [this message]
2025-10-22  1:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPcjP24rdKSLmM5g@fedora \
    --to=i.shihao.999@gmail.com \
    --cc=--cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.