Re: [PATCH] exfat: fix refcount leak in exfat_find

[Shuhao Fu <sfual@cse.ust.hk>]

On Tue, Oct 21, 2025 at 08:21:57AM +0000, Yuezhang.Mo@sony.com wrote:
> On Tue, Oct 21, 2025 16:04 Shuhao Fu <sfual@cse.ust.hk> wrote:
> > On Tue, Oct 21, 2025 at 01:38:29AM +0000, Yuezhang.Mo@sony.com wrote:
> > > On Mon, Oct 20, 2025 23:00 Shuhao Fu <sfual@cse.ust.hk> wrote:
> > > 
> > > I think it would be better to move these checks after exfat_put_dentry_set().
> > > Because the following check will correct ->valid_size and ->size.
> > > 
> > >         if (!is_valid_cluster(sbi, info->start_clu) && info->size) {
> > >                 exfat_warn(sb, "start_clu is invalid cluster(0x%x)",
> > >                                 info->start_clu);
> > >                 info->size = 0;
> > >                 info->valid_size = 0;
> > >         }
> > > 
> > 
> > Do you mean that we should put these two checks after
> > `exfat_put_dentry_set`, like below?
> > 
> 
> Yes, that's what I mean.
> 

Thank you for your suggestion. Patch v2 has been sent out addressing
your comments.

https://lore.kernel.org/linux-fsdevel/aPdHWFiCupwDRiFM@osx.local/