From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AE20CCD184 for ; Tue, 21 Oct 2025 09:58:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1146954.1479286 (Exim 4.92) (envelope-from ) id 1vB97w-0004Ig-6L; Tue, 21 Oct 2025 09:58:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1146954.1479286; Tue, 21 Oct 2025 09:58:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vB97w-0004IZ-3K; Tue, 21 Oct 2025 09:58:00 +0000 Received: by outflank-mailman (input) for mailman id 1146954; Tue, 21 Oct 2025 09:57:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vB97u-0004IP-ME for xen-devel@lists.xenproject.org; Tue, 21 Oct 2025 09:57:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1vB97u-00CfXG-0F; Tue, 21 Oct 2025 09:57:58 +0000 Received: from [2a01:e0a:1da:8420:b77:bd5:6e45:7633] (helo=l14) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vB97t-005Tey-2u; Tue, 21 Oct 2025 09:57:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=1Gsvqf3e/LzqT4p8LcpYiLytYpOlg0dgQVtmRDGm5Bw=; b=f0oZ5aqtzoHgZNMwi5CuTJNSTQ pmn2ablG0HC0EEH60vhTsjFG+XYiVNkfKzxp4yVRYMTFeG7UIjXrpPhml3KDY6iLiULTpG/lvvYOm ZdWqFmeJqLLitDbDJQHSmktIqMB80JGPgwA/jJDB68RoQujhZYdeixqf+YUAJFDCTLxY=; Date: Tue, 21 Oct 2025 11:57:56 +0200 From: Anthony PERARD To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, oleksii.kurochko@gmail.com, Anthony PERARD Subject: Re: [PATCH for-4.21] tools/xl: fix for dead code in list_domains_details() Message-ID: References: <20251020121959.54337-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251020121959.54337-1-roger.pau@citrix.com> On Mon, Oct 20, 2025 at 01:19:59PM +0100, Roger Pau Monne wrote: > Commit d0193c6d6716 introduced checking for the return value of > printf_info_one_json(), but failed to remove a further check down, which > now Coverity complains is dead code. > > The correct fix is to make the call to json_object_array_add() conditional > on printf_info_one_json() having been successful, so that the further call > to libxl_domain_config_dispose() is not avoided. > > CID: 1667251 > Fixes: d0193c6d6716 ("tools/xl: check return value of printf_info_one_json() in list_domains_details()") > Signed-off-by: Roger Pau Monné Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD