From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-hardening@vger.kernel.org
Subject: [PATCH][next] net: inet_sock.h: Avoid thousands of -Wflex-array-member-not-at-end warnings
Date: Tue, 21 Oct 2025 12:43:30 +0100 [thread overview]
Message-ID: <aPdx4iPK4-KIhjFq@kspp> (raw)
Use the new TRAILING_OVERLAP() helper to fix 2600 of the following
warnings:
2600 ./include/net/inet_sock.h:65:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
This helper creates a union between a flexible-array member (FAM)
and a set of members that would otherwise follow it (in this case
`char data[40];) This overlays the trailing members (data) onto the FAM
(__data) while keeping the FAM and the start of MEMBERS aligned.
The static_assert() ensures this alignment remains, and it's
intentionally placed inmediately after `struct ip_options_data`
(no blank line in between).
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
I think it's worth mentioning that the introduction of the new
TRAILING_OVERLAP() helper saves us from making changes like the
following, for this particular case:
https://lore.kernel.org/linux-hardening/ZzK-n_C2yl8mW2Tz@kspp/
Thanks
include/net/inet_sock.h | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/include/net/inet_sock.h b/include/net/inet_sock.h
index 1086256549fa..a974588803af 100644
--- a/include/net/inet_sock.h
+++ b/include/net/inet_sock.h
@@ -62,9 +62,12 @@ struct ip_options_rcu {
};
struct ip_options_data {
- struct ip_options_rcu opt;
- char data[40];
+ TRAILING_OVERLAP(struct ip_options_rcu, opt, opt.__data,
+ char data[40];
+ );
};
+static_assert(offsetof(struct ip_options_data, opt.opt.__data) ==
+ offsetof(struct ip_options_data, data));
struct inet_request_sock {
struct request_sock req;
--
2.43.0
next reply other threads:[~2025-10-21 11:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 11:43 Gustavo A. R. Silva [this message]
2025-10-21 15:58 ` [PATCH][next] net: inet_sock.h: Avoid thousands of -Wflex-array-member-not-at-end warnings Simon Horman
2025-10-24 0:25 ` Jakub Kicinski
2025-10-24 11:24 ` Gustavo A. R. Silva
2025-10-24 23:23 ` Jakub Kicinski
2025-11-18 4:36 ` Gustavo A. R. Silva
2025-11-18 20:27 ` Jakub Kicinski
2025-11-19 22:40 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPdx4iPK4-KIhjFq@kspp \
--to=gustavoars@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.