Re: [PATCH 2/3] Makefile: Add support for legacy kernels

[Clark Williams <williams@redhat.com>]

On Mon, Oct 20, 2025 at 11:48:16AM -0500, Crystal Wood wrote:
> On Fri, 2025-10-17 at 13:01 +0000, Clark Williams wrote:
> > On Tue, Oct 7, 2025 at 6:51 PM Crystal Wood <crwood@redhat.com> wrote:
> > > 
> > > Speaking of SOPTS, is this tool intended to be Red Hat specific
> > > (and require redhat-rpm-config even if no RPM building is intended)?
> > > 
> > > 
> > 
> > No, I really don't like that we have it there in the main Makefile. 
> > Unfortunately we can't push it to the packaging phase since it
> > affects things generated at compilation time. 
> > 
> > Perhaps we need to have a Makefile variable that identifies a
> > "distro" and triggers inclusion of a Makefile.<distro> that modifies
> > the appropriate flags?  I know it's ugly but I'd like to give other
> > folks (suse, cannonical, etc) a way to tweak the build.  We could
> > default the variable to "redhat" and have a block that includes
> > Makefile.redhat to modify the CFLAGS appropriately. 
> 
> Why can't the specfile build phase pass in the cflags it wants to add
> (after fixing the makefile so that it appends to cflags rather than
> replacing it)?
> 
> Ideally upstream shouldn't have to know about specific distros at all...
> 
> -Crystal
> 

That's a good point. We can have the specfile pass in additions to the 
CFLAGS (or completely override them, I suppose). 

Since Wander and I usually do the package builds for Fedora and CentOS/RHEL,
I'll talk to him about doing just that. 

Clark

-- 
The United States Coast Guard
Ruining Natural Selection since 1790