From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Chuck Lever <cel@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org, Mike Snitzer <snitzer@kernel.org>
Subject: Re: [PATCH v4 2/3] NFSD: Implement NFSD_IO_DIRECT for NFS WRITE
Date: Wed, 22 Oct 2025 04:17:56 -0700 [thread overview]
Message-ID: <aPi9ZE96CYQFk5qC@infradead.org> (raw)
In-Reply-To: <63a440d869e3f8a9ecf13537e2da6c6439933ed1.camel@kernel.org>
On Wed, Oct 22, 2025 at 06:15:44AM -0400, Jeff Layton wrote:
> Cache coherency. If the timestamps roll back, some clients may not
> notice that data has changed after a write.
>
> It's not the end of the world -- non-evident timestamp changes were
> typical prior to the multigrain timestamp patches going in, but it's
> not ideal.
Well, in that case nfsd_vfs_write needs to use IOCB_SYNC as well.
And both that and this code need a big fat comment about it.
next prev parent reply other threads:[~2025-10-22 11:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 0:54 [PATCH v4 0/3] NFSD: Implement NFSD_IO_DIRECT for NFS WRITE Chuck Lever
2025-10-18 0:54 ` [PATCH v4 1/3] NFSD: Enable return of an updated stable_how to NFS clients Chuck Lever
2025-10-20 7:02 ` Christoph Hellwig
2025-10-18 0:54 ` [PATCH v4 2/3] NFSD: Implement NFSD_IO_DIRECT for NFS WRITE Chuck Lever
2025-10-20 7:19 ` Christoph Hellwig
2025-10-20 13:56 ` Chuck Lever
2025-10-20 14:05 ` Christoph Hellwig
2025-10-20 16:27 ` Mike Snitzer
2025-10-22 5:14 ` Christoph Hellwig
2025-10-22 14:37 ` Chuck Lever
2025-10-23 5:46 ` Christoph Hellwig
2025-10-21 11:24 ` Jeff Layton
2025-10-22 5:16 ` Christoph Hellwig
2025-10-22 10:15 ` Jeff Layton
2025-10-22 11:17 ` Christoph Hellwig [this message]
2025-10-22 11:30 ` Jeff Layton
2025-10-22 13:31 ` Chuck Lever
2025-10-23 5:27 ` Christoph Hellwig
2025-10-22 17:59 ` Chuck Lever
2025-10-23 5:52 ` Christoph Hellwig
2025-10-18 0:54 ` [PATCH v4 3/3] svcrdma: Mark Read chunks Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPi9ZE96CYQFk5qC@infradead.org \
--to=hch@infradead.org \
--cc=cel@kernel.org \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=snitzer@kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.