From: Florian Westphal <fw@strlen.de>
To: Antonio Ojea <aojea@google.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Eric Dumazet <edumazet@google.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] selftests: nft_queue: conntrack expiration requeue
Date: Wed, 22 Oct 2025 13:26:13 +0200 [thread overview]
Message-ID: <aPi_VdZpVjWujZ29@strlen.de> (raw)
In-Reply-To: <CAAdXToQ+DuBsPGQUgSCk2=f_b2222iTD4-rT=0gVuaYWT7A2HQ@mail.gmail.com>
Antonio Ojea <aojea@google.com> wrote:
> > So I went with 'no rules that adds one, no need for ct label
> > extension space allocation'.
>
> But that does not consider the people that just use netlink to set the
> labels ... from a 1k altitude , can you do a check on the first
> update/create/delete label to initialize the extension?
Yes, but in that case it is not possible to disable it again.
Rule based on/off means we can disable it once the rule is gone.
I'd propose to extend the label allocation to when a 'ct lablel'
rule is added rather than just 'ct label set'.
> Another question related, is it required for the label value to be
> always 16 bytes?
As far as I can see ctnetlink enforces the len must be a multiple of 4
and at most 16 bytes.
next prev parent reply other threads:[~2025-10-22 11:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 20:08 [PATCH] selftests: nft_queue: conntrack expiration requeue Antonio Ojea
2025-10-20 20:55 ` Florian Westphal
2025-10-20 21:23 ` Antonio Ojea
2025-10-20 22:08 ` Florian Westphal
2025-10-21 10:40 ` Antonio Ojea
2025-10-21 10:45 ` Florian Westphal
2025-10-21 12:05 ` Antonio Ojea
2025-10-21 12:18 ` Florian Westphal
2025-10-21 21:57 ` Antonio Ojea
2025-10-22 11:26 ` Florian Westphal [this message]
2025-10-22 14:15 ` Antonio Ojea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPi_VdZpVjWujZ29@strlen.de \
--to=fw@strlen.de \
--cc=aojea@google.com \
--cc=edumazet@google.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.