From: Sabrina Dubroca <sd@queasysnail.net>
To: Ralf Lici <ralf@mandelbit.com>
Cc: netdev@vger.kernel.org,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Antonio Quartulli <antonio@openvpn.net>
Subject: Re: [PATCH net v3 2/3] espintcp: use datagram_poll_queue for socket readiness
Date: Wed, 22 Oct 2025 16:13:16 +0200 [thread overview]
Message-ID: <aPjmfMRSRielEIYK@krikkit> (raw)
In-Reply-To: <20251021100942.195010-3-ralf@mandelbit.com>
2025-10-21, 12:09:41 +0200, Ralf Lici wrote:
> espintcp uses a custom queue (ike_queue) to deliver packets to
> userspace. The polling logic relies on datagram_poll, which checks
> sk_receive_queue, which can lead to false readiness signals when that
> queue contains non-userspace packets.
>
> Switch espintcp_poll to use datagram_poll_queue with ike_queue, ensuring
> poll only signals readiness when userspace data is actually available.
>
> Fixes: e27cca96cd68 ("xfrm: add espintcp (RFC 8229)")
> Signed-off-by: Ralf Lici <ralf@mandelbit.com>
> ---
> net/xfrm/espintcp.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
--
Sabrina
next prev parent reply other threads:[~2025-10-22 14:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 10:09 [PATCH net v3 0/3] fix poll behaviour for TCP-based tunnel protocols Ralf Lici
2025-10-21 10:09 ` [PATCH net v3 1/3] net: datagram: introduce datagram_poll_queue for custom receive queues Ralf Lici
2025-10-22 14:12 ` Sabrina Dubroca
2025-10-22 18:56 ` Antonio Quartulli
2025-10-21 10:09 ` [PATCH net v3 2/3] espintcp: use datagram_poll_queue for socket readiness Ralf Lici
2025-10-22 14:13 ` Sabrina Dubroca [this message]
2025-10-21 10:09 ` [PATCH net v3 3/3] ovpn: use datagram_poll_queue for socket readiness in TCP Ralf Lici
2025-10-22 14:18 ` Sabrina Dubroca
2025-10-23 8:03 ` Antonio Quartulli
2025-10-23 14:00 ` [PATCH net v3 0/3] fix poll behaviour for TCP-based tunnel protocols patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPjmfMRSRielEIYK@krikkit \
--to=sd@queasysnail.net \
--cc=antonio@openvpn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@mandelbit.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.