From: Gregory Price <gourry@gourry.net>
To: SeongJae Park <sj@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, akpm@linux-foundation.org, vbabka@suse.cz,
surenb@google.com, mhocko@suse.com, jackmanb@google.com,
hannes@cmpxchg.org, ziy@nvidia.com,
David Hildenbrand <david@redhat.com>
Subject: Re: [RFC PATCH v2] page_alloc: allow migration of smaller hugepages during contig_alloc.
Date: Wed, 22 Oct 2025 10:53:44 -0400 [thread overview]
Message-ID: <aPjv-Kd2ZihLUqMS@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <20251022014057.128900-1-sj@kernel.org>
On Tue, Oct 21, 2025 at 06:40:57PM -0700, SeongJae Park wrote:
> On Mon, 20 Oct 2025 17:08:16 -0400 Gregory Price <gourry@gourry.net> wrote:
> > +
> > + /* Don't consider moving same size/larger pages */
> > + page = compound_head(page);
> > + order = compound_order(page);
> > + if ((order >= MAX_PAGE_ORDER) ||
> > + (nr_pages < (1 << order)))
> > + return false;
>
> Shouldn't the comparison of 'nr_pages' against '1 << order' use '<=' instead of
> '<', to match the commit description?
>
Good catch, got lost in the shuffle. Thank you!
~Gregory
prev parent reply other threads:[~2025-10-22 14:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 21:08 [RFC PATCH v2] page_alloc: allow migration of smaller hugepages during contig_alloc Gregory Price
2025-10-20 23:02 ` Zi Yan
2025-10-21 1:25 ` Wei Yang
2025-10-21 1:28 ` Zi Yan
2025-10-21 9:14 ` Wei Yang
2025-10-21 16:03 ` Gregory Price
2025-10-21 20:15 ` Wei Yang
2025-10-21 1:29 ` Wei Yang
2025-10-21 9:30 ` David Hildenbrand
2025-10-21 16:05 ` Gregory Price
2025-10-22 1:40 ` SeongJae Park
2025-10-22 14:53 ` Gregory Price [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPjv-Kd2ZihLUqMS@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=sj@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.