All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Brendan Jackman <jackmanb@google.com>
Subject: Re: [PATCH v3 3/4] KVM: VMX: Disable L1TF L1 data cache flush if CONFIG_CPU_MITIGATIONS=n
Date: Wed, 22 Oct 2025 08:06:23 -0700	[thread overview]
Message-ID: <aPjy72H6q3CH-BB1@google.com> (raw)
In-Reply-To: <20251022013657.n2he5yabfgunm5vb@desk>

On Tue, Oct 21, 2025, Pawan Gupta wrote:
> On Thu, Oct 16, 2025 at 01:04:16PM -0700, Sean Christopherson wrote:
> > @@ -302,6 +303,16 @@ static int vmx_setup_l1d_flush(enum vmx_l1d_flush_state l1tf)
> >  	return 0;
> >  }
> >  
> > +static int vmx_setup_l1d_flush(void)
> > +{
> > +	/*
> > +	 * Hand the parameter mitigation value in which was stored in the pre
> > +	 * module init parser. If no parameter was given, it will contain
> > +	 * 'auto' which will be turned into the default 'cond' mitigation mode.
> > +	 */
> > +	return vmx_setup_l1d_flush(vmentry_l1d_flush_param);
> 
> A likely typo here, it should be:
> 
> 	return __vmx_setup_l1d_flush(vmentry_l1d_flush_param);

Argh, I have a feeling I clobbered my branch with a --force push, as I remember
fixing this exact problem.  Or maybe I saw Brendan's struggles and thought, "hold
my beer!" :-D

  reply	other threads:[~2025-10-22 15:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16 20:04 [PATCH v3 0/4] KVM: VMX: Unify L1D flush for L1TF Sean Christopherson
2025-10-16 20:04 ` [PATCH v3 1/4] KVM: VMX: Flush CPU buffers as needed if L1D cache flush is skipped Sean Christopherson
2025-10-21 13:34   ` Brendan Jackman
2025-10-21 16:48     ` Sean Christopherson
2025-10-21 23:30       ` Pawan Gupta
2025-10-22  1:20         ` Pawan Gupta
2025-10-27 22:03           ` Jim Mattson
2025-10-27 23:17             ` Pawan Gupta
2025-10-27 23:58               ` Jim Mattson
2025-10-28  0:19                 ` Pawan Gupta
2025-10-28  0:49                   ` Pawan Gupta
2025-10-27 21:09         ` Pawan Gupta
2025-10-21 23:18   ` Pawan Gupta
2025-10-22  1:59     ` Brendan Jackman
2025-10-22 15:04       ` Sean Christopherson
2025-10-16 20:04 ` [PATCH v3 2/4] KVM: VMX: Bundle all L1 data cache flush mitigation code together Sean Christopherson
2025-10-21 13:38   ` Brendan Jackman
2025-10-16 20:04 ` [PATCH v3 3/4] KVM: VMX: Disable L1TF L1 data cache flush if CONFIG_CPU_MITIGATIONS=n Sean Christopherson
2025-10-17 18:40   ` kernel test robot
2025-10-22  1:36   ` Pawan Gupta
2025-10-22 15:06     ` Sean Christopherson [this message]
2025-10-16 20:04 ` [PATCH v3 4/4] KVM: x86: Unify L1TF flushing under per-CPU variable Sean Christopherson
2025-10-22  1:59   ` Pawan Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPjy72H6q3CH-BB1@google.com \
    --to=seanjc@google.com \
    --cc=jackmanb@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.