All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org,
	jirislaby@kernel.org, Gerhard Engleder <eg@keba.com>,
	Daniel Gierlinger <gida@keba.com>
Subject: Re: [PATCH v3 2/2] serial: 8250: add driver for KEBA UART
Date: Thu, 23 Oct 2025 03:56:08 +0200	[thread overview]
Message-ID: <aPmLONW5q55Yta3N@wunner.de> (raw)
In-Reply-To: <20251020190658.30655-3-gerhard@engleder-embedded.com>

On Mon, Oct 20, 2025 at 09:06:58PM +0200, Gerhard Engleder wrote:
> +++ b/drivers/tty/serial/8250/8250_keba.c
> @@ -0,0 +1,281 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2025 KEBA Industrial Automation GmbH
> + *
> + * Driver for KEBA UART FPGA IP core
> + */
> +
> +#include <linux/module.h>
> +#include <linux/io.h>
> +#include <linux/module.h>
> +#include <linux/device.h>
> +#include <linux/auxiliary_bus.h>
> +#include <linux/misc/keba.h>

Duplicate inclusion of <linux/module.h>.

Usually these are sorted alphabetically.

Thanks,

Lukas

  reply	other threads:[~2025-10-23  1:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20 19:06 [PATCH v3 0/2] serial: add KEBA UART driver Gerhard Engleder
2025-10-20 19:06 ` [PATCH v3 1/2] serial: Keep rs485 settings for devices without firmware node Gerhard Engleder
2025-10-23 10:17   ` Lukas Wunner
2025-10-23 15:13     ` Gerhard Engleder
2025-10-20 19:06 ` [PATCH v3 2/2] serial: 8250: add driver for KEBA UART Gerhard Engleder
2025-10-23  1:56   ` Lukas Wunner [this message]
2025-10-23 15:14     ` Gerhard Engleder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPmLONW5q55Yta3N@wunner.de \
    --to=lukas@wunner.de \
    --cc=eg@keba.com \
    --cc=gerhard@engleder-embedded.com \
    --cc=gida@keba.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.