Re: [Patch v7 0/5] hw/core/loader: capture Error from load_image_targphys

[Vishal Chourasia <vishalc@linux.ibm.com>]

Hi Peter, Daniel, Alistair, Balaton,

Does the patch series look good for your ack now?

Thanks

On Thu, Oct 23, 2025 at 12:57:12AM +0530, Vishal Chourasia wrote:
> Currently, when QEMU fails to load images (kernel, BIOS, initrd) via
> load_image_targphys(), the error messages are not descriptive enough
> for users to understand why the loading failed. This series adds the
> ability to add Error information through the loader functions to
> provide more detailed error reporting.
> 
> v7:
> - Dropped the patch [hw/ppc/spapr: Rename resize_hpt_err to errp]
>   already merged. Rebased on latest master.
> 
> v6:
> - Pass error_fatal instead of errp where caller exits right after
>   load_image_targphys() fails
> - Include filename in error messages.
> 
> v5:
> - Moved the patch which replaces open() with qemu_open() earlier in the
>   series
> - Incorporated minor changes in the error messages requested by Balaton
> - Moved check for size zero in load_image_targphys_as() into it's
>   separate patch 
> 
> v4:
> - Reject empty files (`size == 0`) with an appropriate error. [1/5]
> - Populate error when `rom_add_file_fixed_as()` fails. [1/5]
> - Add missing check in hw/ppc/virtex_ml507.c [5/5]
> - Fixed checkpatch warnings [5/5]
> - Check errp for failures from load_image_targphys/load_image_targphys_as [3,5/5]
> - Remove unused variables [5/5]
> 
> v3:
> - Use qemu_open() instead of open() in get_image_size() (danpb)
> - Remove redundant error_setg_file_open() call (danpb)
> - Use error_prepend()/error_reportf_err() to preserve underlying
>   error details (danpb)
> 
> [v6]: https://lore.kernel.org/qemu-devel/20251022132507.1597232-2-vishalc@linux.ibm.com
> [v5]: https://lore.kernel.org/all/20251021105442.1474602-2-vishalc@linux.ibm.com
> [v4]: https://lore.kernel.org/all/20251017181250.1421446-2-vishalc@linux.ibm.com
> [v3]: https://lore.kernel.org/all/20251016173502.1261674-1-vishalc@linux.ibm.com
> [v2]: https://lore.kernel.org/all/20251015134716.1099351-2-vishalc@linux.ibm.com
> [v1]: https://lore.kernel.org/all/20251007091214.403430-2-vishalc@linux.ibm.com
> 
> Vishal Chourasia (5):
>   hw/core/loader: Use qemu_open() instead of open() in get_image_size()
>   hw/core/loader: capture Error from load_image_targphys
>   hw/core/loader: add check for zero size in load_image_targphys_as
>   hw/core: Pass errp to load_image_targphys_as()
>   hw/ppc: Pass errp to load_image_targphys() and report errors
> 
>  hw/alpha/dp264.c         |  4 ++--
>  hw/arm/armv7m.c          |  2 +-
>  hw/arm/boot.c            |  5 +++--
>  hw/arm/digic_boards.c    |  2 +-
>  hw/arm/highbank.c        |  3 ++-
>  hw/arm/raspi.c           |  2 +-
>  hw/arm/vexpress.c        |  2 +-
>  hw/core/generic-loader.c |  8 +++++---
>  hw/core/guest-loader.c   |  7 ++++---
>  hw/core/loader.c         | 37 +++++++++++++++++++++++++++++--------
>  hw/hppa/machine.c        |  5 +++--
>  hw/i386/multiboot.c      |  2 +-
>  hw/i386/x86-common.c     |  4 ++--
>  hw/ipmi/ipmi_bmc_sim.c   |  2 +-
>  hw/loongarch/boot.c      |  5 ++---
>  hw/m68k/an5206.c         |  2 +-
>  hw/m68k/mcf5208.c        |  4 ++--
>  hw/m68k/next-cube.c      |  2 +-
>  hw/m68k/q800.c           |  7 ++++---
>  hw/m68k/virt.c           |  4 ++--
>  hw/microblaze/boot.c     |  5 +++--
>  hw/mips/boston.c         |  2 +-
>  hw/mips/fuloong2e.c      |  9 +++++----
>  hw/mips/jazz.c           |  2 +-
>  hw/mips/loongson3_virt.c | 10 ++++++----
>  hw/mips/malta.c          |  9 +++++----
>  hw/nubus/nubus-device.c  |  2 +-
>  hw/openrisc/boot.c       |  5 +++--
>  hw/pci/pci.c             |  2 +-
>  hw/ppc/amigaone.c        | 13 ++-----------
>  hw/ppc/e500.c            | 20 ++++----------------
>  hw/ppc/mac_newworld.c    | 19 ++++++-------------
>  hw/ppc/mac_oldworld.c    | 19 ++++++-------------
>  hw/ppc/pegasos2.c        | 10 +++-------
>  hw/ppc/pnv.c             | 27 ++++++---------------------
>  hw/ppc/ppc440_bamboo.c   |  9 ++-------
>  hw/ppc/prep.c            | 19 ++++++-------------
>  hw/ppc/sam460ex.c        |  8 ++------
>  hw/ppc/spapr.c           | 17 ++++-------------
>  hw/ppc/virtex_ml507.c    | 11 +++--------
>  hw/riscv/boot.c          |  7 ++++---
>  hw/rx/rx-gdbsim.c        |  2 +-
>  hw/s390x/ipl.c           |  8 +++++---
>  hw/sh4/r2d.c             |  8 +++++---
>  hw/smbios/smbios.c       |  2 +-
>  hw/sparc/leon3.c         |  4 ++--
>  hw/sparc/sun4m.c         |  8 +++++---
>  hw/sparc64/sun4u.c       |  7 ++++---
>  hw/xtensa/xtfpga.c       |  3 ++-
>  include/hw/loader.h      |  8 +++++---
>  system/device_tree.c     |  2 +-
>  51 files changed, 173 insertions(+), 213 deletions(-)
> 
> -- 
> 2.51.0
> 
>