From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: "Aditya Dutt" <duttaditya18@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>, "Frank Zago" <frank@zago.net>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: position: Add support for ams AS5600 angle sensor
Date: Thu, 23 Oct 2025 21:32:55 +0300 [thread overview]
Message-ID: <aPp010RxM3Dp_fAd@smile.fi.intel.com> (raw)
In-Reply-To: <20251023191627.00003b52@huawei.com>
On Thu, Oct 23, 2025 at 07:16:27PM +0100, Jonathan Cameron wrote:
> On Tue, 21 Oct 2025 01:46:53 +0530
> Aditya Dutt <duttaditya18@gmail.com> wrote:
...
> > + if (chan->channel == 0) {
> > + /* Whole angle range = 2*pi / 4096 */
> > + *val = 2 * 3141592;
Can you, please, add a definition of PI * 10^6 to units.h? We have already
users of this value and of the PI * 10^5.
...
> > + /* Partial angle = (range / 4096) * (2*pi / 4096) */
> Use multi line comment syntax for htis.
Also you may use Greek PI (as unicode character) in the comments and messages.
We've been living decades in the unicode time!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-10-23 18:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 20:16 [PATCH 0/2] New driver for ams AS5600 Position Sensor Aditya Dutt
2025-10-20 20:16 ` [PATCH 1/2] dt-bindings: iio: position: Add " Aditya Dutt
2025-10-22 17:50 ` Conor Dooley
2025-10-20 20:16 ` [PATCH 2/2] iio: position: Add support for ams AS5600 angle sensor Aditya Dutt
2025-10-20 23:45 ` Frank Zago
2025-10-21 11:38 ` kernel test robot
2025-10-21 12:14 ` kernel test robot
2025-10-23 18:16 ` Jonathan Cameron
2025-10-23 18:32 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPp010RxM3Dp_fAd@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=duttaditya18@gmail.com \
--cc=frank@zago.net \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.