From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B010264A86 for ; Thu, 23 Oct 2025 18:35:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761244502; cv=none; b=aCGOe0Z/6noUCtDG5xfH/5YlySqfKCDpbFI09r3fw327RZNX3bgAqNVJgRo8hDf9LmaqpCEECn60HtQgVukLzqZms0fnmo4SnJiqIA7AWhAGZf/5ZxxhS6Ahk6K/TwXEnhBFaj98eZEYm6HfJpoOyiBXQKuh4g6yjqya/ujDt28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761244502; c=relaxed/simple; bh=SPUax74LgvfnS22qRNjdPzNnSFPqKgRwa5WTYIXEV2M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N1xwlRXCOXP9lxz+9JAO7BKKKgpk1ExciL/FuIRnKt3KqUgzjMq7HwNu754fd+EI2nP1EnDbGqU/a+5/bYACJfriZdDVTcCK3Qx4EWPS5+JCiFcn/i2kaBAOXZm4t3GLsm2WOKZVxMiMWYLQ9f3m4Rj6O4h6UMAg98CNWw3UmTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=DL6YeJYr; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DL6YeJYr" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-27d4d6b7ab5so16522015ad.2 for ; Thu, 23 Oct 2025 11:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1761244500; x=1761849300; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6nuoMJ97qtbUY/Trjdlag2VQw68geuw/k2BTI9Rt2oo=; b=DL6YeJYr1kW5Rw3mb09Im2XHQ1NT+I54WfNmAWU2wSUJthMFfrGpCyhRQG5sXFJxWw OEUOstKm0pBBLhF3ON0szIvJfwwGKUuGqEJbAUgcowty/wWqUKL4VaCuvsiMoEJSSyLI 5LBDlEArecCTcXScf74+1yQwJvf3Yj+rs0ET8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761244500; x=1761849300; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6nuoMJ97qtbUY/Trjdlag2VQw68geuw/k2BTI9Rt2oo=; b=afYnOyd92SYKxhwiyZNMIIwfHfu/esRXDMEAz8U2gUlJDZjovAuGdJwcD53tu4g8yT bRH0tKNX7zQhw5Mt3fqch10nPMTsze8QMS5foHh3coc/gKlzz+WdN83/WeiRQIjlRbU6 HHU0D5iWZjPKXOT1prnt8LNa4P+UKknlG9gbSqefbXoIrz6NgKJzCfUeuGUXASfK8cHz VlwirUy1qOnZMfOQDZgJoI5WwLqgQbVBCKPqtPZaB3Z5oUDGXgjBfFnVaYBEnx04SM30 orMlaA/xCuAzouVPv9DYuv+s8zEAVhWDWLveZx8x6QG39r0Xx8TKv/q6hBjpAqZMh9fi NRew== X-Forwarded-Encrypted: i=1; AJvYcCXeveeOWo2t/YfvtgfR0zSpBdPZ/gitHVt2Not2mWmz19AXQhMh3JP/qerkfylRqBhwTUWoQjiHzAw=@vger.kernel.org X-Gm-Message-State: AOJu0YyTXoTu+v745y78UO31CZsem4n3PCOLcGwMs1QVVMlNLXgdNvS4 PmjBieQXWLY9N5s3Un8lri5f2K/yCBueTkOmGW7rJpNNFlp6wSBM63A1FgUQ8EP5QglR+RR7f+b 8uIs= X-Gm-Gg: ASbGncvuT9FgLbaoIj4GX7XQ1i4TMmH5SVznxGm3OTyWImHK3HgtWLgt+wPpVYokYif NjmR3rm3twH4yCBnVk8kc5AWRfTg8UrW6+pLswOCYDTaomP5OlVhFc485cmm/KTOqoQcelgxfVz sjEpGzQB4Q1vFpGnwiyvWWlBD10r5K3c0VHZZjM6IIP6KNNuHSXqU2dawVDD/IfocOpZQ5cw7Cz pl6cxMM5IuhmQ6yRwGOCDsHJ2j9RcfO8rBdqLk4ba/VDTk0c3ir3PDkATQ3QPr7BTkOI8ieW2QQ g17igHBfyykAMm/tz0GaWoUbNcLpbIkrphkxcQIpzpPvnyjRuJsquNRVimJo6JK5LKHx0TLdb5O BQkvjbh2Lf9TorYsxtJaEguOa3fDnrtFUehcNVnaeWqupRQyNNVRWHBEiZan1r32i5zqPW86kLs RMMrx7ZsXbXicfBAYmxZZJB+YSVUTiDwNAP9FNuUe0IitjXEad X-Google-Smtp-Source: AGHT+IF9nl11vVtaakhDyS6lQfmP3vdzYGTg2RcSslOSdH+UpIhSi4MDwaT7++gY/SFq1hZJySLLIg== X-Received: by 2002:a17:903:2b06:b0:25c:b543:2da7 with SMTP id d9443c01a7336-290c9c93a96mr296576605ad.9.1761244499572; Thu, 23 Oct 2025 11:34:59 -0700 (PDT) Received: from localhost ([2a00:79e0:2e7c:8:839c:d3ee:bea4:1b90]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-2946e2578desm30119195ad.106.2025.10.23.11.34.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 11:34:59 -0700 (PDT) Date: Thu, 23 Oct 2025 11:34:57 -0700 From: Brian Norris To: "Rafael J. Wysocki" Cc: Bjorn Helgaas , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Wunner Subject: Re: [PATCH v3] PCI/PM: Prevent runtime suspend before devices are fully initialized Message-ID: References: <20251022141434.v3.1.I60a53c170a8596661883bd2b4ef475155c7aa72b@changeid> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Oct 23, 2025 at 11:41:38AM +0200, Rafael J. Wysocki wrote: > On Wed, Oct 22, 2025 at 11:15 PM Brian Norris wrote: > > > > Today, it's possible for a PCI device to be created and > > runtime-suspended before it is fully initialized. When that happens, the > > device will remain in D0, but the suspend process may save an > > intermediate version of that device's state -- for example, without > > appropriate BAR configuration. When the device later resumes, we'll > > restore invalid PCI state and the device may not function. > > > > Prevent runtime suspend for PCI devices by deferring pm_runtime_enable() > > until we've fully initialized the device. > > > > More details on how exactly this may occur: > > > > 1. PCI device is created by pci_scan_slot() or similar > > 2. As part of pci_scan_slot(), pci_pm_init() enables runtime PM; the > > device starts "active" and we initially prevent (pm_runtime_forbid()) > > suspend -- but see [*] footnote > > 3. Underlying 'struct device' is added to the system (device_add()); > > runtime PM can now be configured by user space > > 4. PCI device receives BAR configuration > > (pci_assign_unassigned_bus_resources(), etc.) > > 5. PCI device is added to the system in pci_bus_add_device() > > > > The device may potentially suspend between #3 and #4. > > > > [*] By default, pm_runtime_forbid() prevents suspending a device; but by > > design [**], this can be overridden by user space policy via > > > > echo auto > /sys/bus/pci/devices/.../power/control > > > > Thus, the above #3/#4 sequence is racy with user space (udev or > > similar). > > > > Notably, many PCI devices are enumerated at subsys_initcall time and so > > will not race with user space. However, there are several scenarios > > where PCI devices are created later on, such as with hotplug or when > > drivers (pwrctrl or controller drivers) are built as modules. > > > > [**] The relationship between pm_runtime_forbid(), pm_runtime_allow(), > > /sys/.../power/control, and the runtime PM usage counter can be subtle. > > It appears that the intention of pm_runtime_forbid() / > > pm_runtime_allow() is twofold: > > > > 1. Allow the user to disable runtime_pm (force device to always be > > powered on) through sysfs. > > 2. Allow the driver to start with runtime_pm disabled (device forced > > on) and user space could later enable runtime_pm. > > > > This conclusion comes from reading `Documentation/power/runtime_pm.rst`, > > specifically the section starting "The user space can effectively > > disallow". > > > > This means that while pm_runtime_forbid() does technically increase the > > runtime PM usage counter, this usage counter is not a guarantee of > > functional correctness, because sysfs can decrease that count again. > > > > Link: https://lore.kernel.org/all/20251016155335.1.I60a53c170a8596661883bd2b4ef475155c7aa72b@changeid/ > > Signed-off-by: Brian Norris > > Cc: > > Reviewed-by: Rafael J. Wysocki (Intel) > > --- > > > > Changes in v3: > > * Add Link to initial discussion > > * Add Rafael's Reviewed-by > > * Add lengthier footnotes about forbid vs allow vs sysfs > > > > Changes in v2: > > * Update CC list > > * Rework problem description > > * Update solution: defer pm_runtime_enable(), instead of trying to > > get()/put() > > > > drivers/pci/bus.c | 3 +++ > > drivers/pci/pci.c | 1 - > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c > > index f26aec6ff588..fc66b6cb3a54 100644 > > --- a/drivers/pci/bus.c > > +++ b/drivers/pci/bus.c > > @@ -14,6 +14,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > @@ -375,6 +376,8 @@ void pci_bus_add_device(struct pci_dev *dev) > > put_device(&pdev->dev); > > } > > > > + pm_runtime_enable(&dev->dev); > > + > > if (!dn || of_device_is_available(dn)) > > pci_dev_allow_binding(dev); > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > index b14dd064006c..f792164fa297 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -3226,7 +3226,6 @@ void pci_pm_init(struct pci_dev *dev) > > pci_pm_power_up_and_verify_state(dev); > > pm_runtime_forbid(&dev->dev); > > pm_runtime_set_active(&dev->dev); > > Actually, I think that the two statements above can be moved too. > > The pm_runtime_forbid() call doesn't matter until runtime PM is > enabled and it is better to do pm_runtime_set_active() right before > enabling runtime PM. Ehh, sure, I can do that I suppose. That signs me up for fixing some excessive Documentation/ that spells out exactly what goes on in pci_pm_init() for some reason, but I can do that too :) Brian > > - pm_runtime_enable(&dev->dev); > > } > > > > static unsigned long pci_ea_flags(struct pci_dev *dev, u8 prop) > > --