From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kartik Rajput <kkartik@nvidia.com>
Cc: alexandre.belloni@bootlin.com, thierry.reding@gmail.com,
jonathanh@nvidia.com, linux-rtc@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] rtc: tegra: Use devm_clk_get_enabled() in probe
Date: Thu, 23 Oct 2025 21:05:55 +0300 [thread overview]
Message-ID: <aPpug9kcQwQlhivK@smile.fi.intel.com> (raw)
In-Reply-To: <20251023093042.770798-1-kkartik@nvidia.com>
On Thu, Oct 23, 2025 at 03:00:40PM +0530, Kartik Rajput wrote:
> Simplify clock management by replacing devm_clk_get() and manual clock
> enable/disable with devm_clk_get_enabled(). This also simplifies the
> error handling logic.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
with the caveat that you need to remove ->remove() altogether as well.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-10-23 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 9:30 [PATCH v3 1/3] rtc: tegra: Use devm_clk_get_enabled() in probe Kartik Rajput
2025-10-23 9:30 ` [PATCH v3 2/3] rtc: tegra: Add ACPI support Kartik Rajput
2025-10-23 18:04 ` Andy Shevchenko
2025-10-23 9:30 ` [PATCH v3 3/3] rtc: tegra: Drop deprecated SIMPLE_DEV_PM_OPS Kartik Rajput
2025-10-23 18:04 ` Andy Shevchenko
2025-10-23 18:05 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPpug9kcQwQlhivK@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.