Re: [PATCH] perf hwmon_pmu: Fix uninitialized variable warning

[Namhyung Kim <namhyung@kernel.org>]

On Thu, Oct 23, 2025 at 03:11:37PM -0700, Tony Jones wrote:
> On Thu, Oct 23, 2025 at 02:50:43PM -0700, Namhyung Kim wrote:
> > Hello,
> > 
> > On Wed, Oct 22, 2025 at 12:38:35PM +0200, Michal Suchanek wrote:
> > > The line_len is only set on success. Check the return value instead.
> > 
> > Can you please share the actual warning messages from the compiler?
> > 
> > Thanks,
> > Namhyung
> 
> [snipped CC]
> 
> I believe it was the following (gcc13):
> 
> [   38s] util/hwmon_pmu.c: In function ‘perf_pmus__read_hwmon_pmus’:
> [   38s] util/hwmon_pmu.c:742:20: warning: ‘line_len’ may be used uninitialized [-Wmaybe-uninitialized]
> [   38s]   742 |                 if (line_len > 0 && line[line_len - 1] == '\n')
> [   38s]       |                    ^
> [   38s] util/hwmon_pmu.c:719:24: note: ‘line_len’ was declared here
> [   38s]   719 |                 size_t line_len;
> [   38s]  

Great, I'll add this to the commit log.

Thanks,
Namhyung