From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E98DCCCD1AB for ; Fri, 24 Oct 2025 08:16:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pjX84FlJTTBQtWdQ8pCfYrZfYBz66C6I1Vwctt0TxSQ=; b=I9X0+YR1eiCLllZ2C/9I/R/uLo PueS1OtFAxOL9bLQyqw33Z73QqlzDet+jcXU7GNIfBNvUvHeErZwHY4bZ7+hTUSRRwfm6rSNgmFFj Cq1z1glLCOroUsajGoTjGUzOub5LNr/jJ25fnw+cR/tzsUVnE+7eNOOXQUZSEKqj2ZcweXIBn8G58 du+sWOwQcdBGMPqShfro09WSZyYjfzJdv6wYuPYXFyfMCTuJZunXkUt6lyFtezHN6jFfKxYAlqDmq QOYFdDcLAh7Dxm9xoAQOErRFXNn10qflj1FqaL0SZUEZ4Hsu3HaGESU8cZoMJ3Oj9ATTc99WfBrKV WH5IvxJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vCCyO-00000008elS-0ZJa; Fri, 24 Oct 2025 08:16:32 +0000 Received: from mgamail.intel.com ([192.198.163.9]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vCCyL-00000008ek5-1fjz; Fri, 24 Oct 2025 08:16:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761293789; x=1792829789; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Y6hIryfME2/PZmCw4H4nq4PMUJueVx80pY8OjCr1KyY=; b=g4iS8vy6q5JvMmzMps77tHvI90cEA4UYPIvl0SdkIAmyc/4CGdjeAts6 mqc+I5nZ5dAAjCFANskfCZv/Aomj7+74nngllAugfs5M8uS84buN/0q2k 0RwJerjflp9EnA025DOiAs6P+DXQKnpssePSUD+rLJVBkVqJ7JkWSHTcD R5Ux0FacINPl80akVR3pte8gyI+KkTb6HPQEyDFRLC0WWJaOqk0x6bq25 T/w0Pc6PIX7QcC+ZS4MH4v6v5lmDVrKqWbdcIDwAN3dcQQcAJkzdQDrEc P2NcvujPA8r9NWSXtEZtvc97KGwRdJxNVjcZjm9c5V5mLbH2On9yKWjFX w==; X-CSE-ConnectionGUID: Mwh9IKP8QBSLboapypycug== X-CSE-MsgGUID: uEmi6GoYRTu9IDZCiobvgA== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="74145052" X-IronPort-AV: E=Sophos;i="6.19,251,1754982000"; d="scan'208";a="74145052" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2025 01:16:28 -0700 X-CSE-ConnectionGUID: Chd3dXKyQl6vo1nUEb8nyA== X-CSE-MsgGUID: CnAOpA8XQ3utXO3rexXLig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,251,1754982000"; d="scan'208";a="215297555" Received: from mjruhl-desk.amr.corp.intel.com (HELO kuha.fi.intel.com) ([10.124.221.255]) by fmviesa001.fm.intel.com with SMTP; 24 Oct 2025 01:16:17 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 24 Oct 2025 11:16:16 +0300 Date: Fri, 24 Oct 2025 11:16:16 +0300 From: Heikki Krogerus To: Chaoyi Chen Cc: Greg Kroah-Hartman , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Chaoyi Chen , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v7 1/9] usb: typec: Add notifier functions Message-ID: References: <20251023033009.90-1-kernel@airkyi.com> <20251023033009.90-2-kernel@airkyi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251023033009.90-2-kernel@airkyi.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251024_011629_446207_4E2EB6A1 X-CRM114-Status: UNSURE ( 7.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > +#include > +#include > + > +static BLOCKING_NOTIFIER_HEAD(typec_notifier_list); > + > +int typec_register_notify(struct notifier_block *nb) > +{ > + return blocking_notifier_chain_register(&typec_notifier_list, nb); > +} > +EXPORT_SYMBOL_GPL(typec_register_notify); > + > +int typec_unregister_notify(struct notifier_block *nb) > +{ > + return blocking_notifier_chain_unregister(&typec_notifier_list, nb); > +} > +EXPORT_SYMBOL_GPL(typec_unregister_notify); Better name these more clearly: typec_altmode_register_notify() typec_altmode_unregister_notify() thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A73F9CCF9E0 for ; Fri, 24 Oct 2025 08:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QEEZ/gOek3sh1ZB1tIUgROvZKfm1CopD+OZpiv7ofzc=; b=39xkRB8V4DCp8C 64Yd0fijetA8ifnMW7esePcdNfqmuXDum8jwVrNwnUzRupemBiV3tGA9JAaEk423Lq0mOm6uup6RU 0J1EJPbmZWa3SDzmRR9saFa5G8FUjj+N9veJvBa/RxmD+5Kk1WlPp58+hYlc+jPc1diwPFXBC2P3U oL1zeUfbReRvwxk+hGml/J9taaWupUoZvE6lIaM1zZh/8OJNoUeinhZysYaDY90fW4+VhQwXcz4Ha cWSR95UTUJvCcMx0+08D5GGRx1gYjaT/Oai0L55ntHU+kUKyZdt3WU3zREWu7z9+ttNCj8Pxgm429 wf0iv1xSQkPGeLf4wyTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vCCyO-00000008ell-1lMS; Fri, 24 Oct 2025 08:16:32 +0000 Received: from mgamail.intel.com ([192.198.163.9]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vCCyL-00000008ek5-1fjz; Fri, 24 Oct 2025 08:16:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761293789; x=1792829789; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Y6hIryfME2/PZmCw4H4nq4PMUJueVx80pY8OjCr1KyY=; b=g4iS8vy6q5JvMmzMps77tHvI90cEA4UYPIvl0SdkIAmyc/4CGdjeAts6 mqc+I5nZ5dAAjCFANskfCZv/Aomj7+74nngllAugfs5M8uS84buN/0q2k 0RwJerjflp9EnA025DOiAs6P+DXQKnpssePSUD+rLJVBkVqJ7JkWSHTcD R5Ux0FacINPl80akVR3pte8gyI+KkTb6HPQEyDFRLC0WWJaOqk0x6bq25 T/w0Pc6PIX7QcC+ZS4MH4v6v5lmDVrKqWbdcIDwAN3dcQQcAJkzdQDrEc P2NcvujPA8r9NWSXtEZtvc97KGwRdJxNVjcZjm9c5V5mLbH2On9yKWjFX w==; X-CSE-ConnectionGUID: Mwh9IKP8QBSLboapypycug== X-CSE-MsgGUID: uEmi6GoYRTu9IDZCiobvgA== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="74145052" X-IronPort-AV: E=Sophos;i="6.19,251,1754982000"; d="scan'208";a="74145052" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2025 01:16:28 -0700 X-CSE-ConnectionGUID: Chd3dXKyQl6vo1nUEb8nyA== X-CSE-MsgGUID: CnAOpA8XQ3utXO3rexXLig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,251,1754982000"; d="scan'208";a="215297555" Received: from mjruhl-desk.amr.corp.intel.com (HELO kuha.fi.intel.com) ([10.124.221.255]) by fmviesa001.fm.intel.com with SMTP; 24 Oct 2025 01:16:17 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 24 Oct 2025 11:16:16 +0300 Date: Fri, 24 Oct 2025 11:16:16 +0300 From: Heikki Krogerus To: Chaoyi Chen Cc: Greg Kroah-Hartman , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Chaoyi Chen , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v7 1/9] usb: typec: Add notifier functions Message-ID: References: <20251023033009.90-1-kernel@airkyi.com> <20251023033009.90-2-kernel@airkyi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251023033009.90-2-kernel@airkyi.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251024_011629_446207_4E2EB6A1 X-CRM114-Status: UNSURE ( 7.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org > +#include > +#include > + > +static BLOCKING_NOTIFIER_HEAD(typec_notifier_list); > + > +int typec_register_notify(struct notifier_block *nb) > +{ > + return blocking_notifier_chain_register(&typec_notifier_list, nb); > +} > +EXPORT_SYMBOL_GPL(typec_register_notify); > + > +int typec_unregister_notify(struct notifier_block *nb) > +{ > + return blocking_notifier_chain_unregister(&typec_notifier_list, nb); > +} > +EXPORT_SYMBOL_GPL(typec_unregister_notify); Better name these more clearly: typec_altmode_register_notify() typec_altmode_unregister_notify() thanks, -- heikki -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04C73CCD1AB for ; Fri, 24 Oct 2025 08:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TxtOXwcl79ykI1BqlO1A8Cbq5ShpL3t3+/BD/R25Lxs=; b=YFy9j8cnNPauC5 VRqryD9jciiswC4DD3kHPEkCeU745rvDWbKqL2Tni1O24jlLi6tCyjjGgDWNqXiB8FvMusAbgAZdm 8YUckatO4taOSYy1jBevtcX3JAMO3WUKeJxYe3gVQxc9MnV/EPJMRX43uhckYRTaLjMDABKTSkUgA WQU/siLI7aK3EaoMb3mrp004fACMmHz7TC5GNm0LH0Dt8AuqSuueZcb81feuxeb89ZYxY80/Tn4Db voa0wFbaP4eYaYV27LTP22Hd/C+b9/Gvii0YiOoxpm7rk9V9rQ9y+dIA6rdA2l2J8m4PiqVE++lx1 kocV9J9F6Aqm+ximnmnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vCCyO-00000008emE-2oTy; Fri, 24 Oct 2025 08:16:32 +0000 Received: from mgamail.intel.com ([192.198.163.9]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vCCyL-00000008ek5-1fjz; Fri, 24 Oct 2025 08:16:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761293789; x=1792829789; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Y6hIryfME2/PZmCw4H4nq4PMUJueVx80pY8OjCr1KyY=; b=g4iS8vy6q5JvMmzMps77tHvI90cEA4UYPIvl0SdkIAmyc/4CGdjeAts6 mqc+I5nZ5dAAjCFANskfCZv/Aomj7+74nngllAugfs5M8uS84buN/0q2k 0RwJerjflp9EnA025DOiAs6P+DXQKnpssePSUD+rLJVBkVqJ7JkWSHTcD R5Ux0FacINPl80akVR3pte8gyI+KkTb6HPQEyDFRLC0WWJaOqk0x6bq25 T/w0Pc6PIX7QcC+ZS4MH4v6v5lmDVrKqWbdcIDwAN3dcQQcAJkzdQDrEc P2NcvujPA8r9NWSXtEZtvc97KGwRdJxNVjcZjm9c5V5mLbH2On9yKWjFX w==; X-CSE-ConnectionGUID: Mwh9IKP8QBSLboapypycug== X-CSE-MsgGUID: uEmi6GoYRTu9IDZCiobvgA== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="74145052" X-IronPort-AV: E=Sophos;i="6.19,251,1754982000"; d="scan'208";a="74145052" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2025 01:16:28 -0700 X-CSE-ConnectionGUID: Chd3dXKyQl6vo1nUEb8nyA== X-CSE-MsgGUID: CnAOpA8XQ3utXO3rexXLig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,251,1754982000"; d="scan'208";a="215297555" Received: from mjruhl-desk.amr.corp.intel.com (HELO kuha.fi.intel.com) ([10.124.221.255]) by fmviesa001.fm.intel.com with SMTP; 24 Oct 2025 01:16:17 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 24 Oct 2025 11:16:16 +0300 Date: Fri, 24 Oct 2025 11:16:16 +0300 From: Heikki Krogerus To: Chaoyi Chen Cc: Greg Kroah-Hartman , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Chaoyi Chen , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v7 1/9] usb: typec: Add notifier functions Message-ID: References: <20251023033009.90-1-kernel@airkyi.com> <20251023033009.90-2-kernel@airkyi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251023033009.90-2-kernel@airkyi.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251024_011629_446207_4E2EB6A1 X-CRM114-Status: UNSURE ( 7.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org > +#include > +#include > + > +static BLOCKING_NOTIFIER_HEAD(typec_notifier_list); > + > +int typec_register_notify(struct notifier_block *nb) > +{ > + return blocking_notifier_chain_register(&typec_notifier_list, nb); > +} > +EXPORT_SYMBOL_GPL(typec_register_notify); > + > +int typec_unregister_notify(struct notifier_block *nb) > +{ > + return blocking_notifier_chain_unregister(&typec_notifier_list, nb); > +} > +EXPORT_SYMBOL_GPL(typec_unregister_notify); Better name these more clearly: typec_altmode_register_notify() typec_altmode_unregister_notify() thanks, -- heikki _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip