All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Lizhi Hou <lizhi.hou@amd.com>
Cc: dri-devel@lists.freedesktop.org
Subject: [bug report] accel/amdxdna: Support firmware debug buffer
Date: Fri, 24 Oct 2025 09:19:33 +0300	[thread overview]
Message-ID: <aPsadTBXunUSBByV@stanley.mountain> (raw)

Hello Lizhi Hou,

Commit 7ea046838021 ("accel/amdxdna: Support firmware debug buffer")
from Oct 16, 2025 (linux-next), leads to the following Smatch static
checker warning:

	drivers/accel/amdxdna/aie2_ctx.c:882 aie2_hwctx_sync_debug_bo()
	warn: missing error code? 'ret'

drivers/accel/amdxdna/aie2_ctx.c
    863 int aie2_hwctx_sync_debug_bo(struct amdxdna_hwctx *hwctx, u32 debug_bo_hdl)
    864 {
    865         struct amdxdna_client *client = hwctx->client;
    866         struct amdxdna_dev *xdna = client->xdna;
    867         struct amdxdna_drv_cmd cmd = { 0 };
    868         u64 seq;
    869         int ret;
    870 
    871         cmd.opcode = SYNC_DEBUG_BO;
    872         ret = amdxdna_cmd_submit(client, &cmd, AMDXDNA_INVALID_BO_HANDLE,
    873                                  &debug_bo_hdl, 1, hwctx->id, &seq);
    874         if (ret) {
    875                 XDNA_ERR(xdna, "Submit command failed");
    876                 return ret;
    877         }
    878 
    879         aie2_cmd_wait(hwctx, seq);
    880         if (cmd.result) {
    881                 XDNA_ERR(xdna, "Response failure 0x%x", cmd.result);
--> 882                 return ret;

ret is zero.  return -EINVAL or something?

    883         }
    884 
    885         return 0;
    886 }

regards,
dan carpenter

             reply	other threads:[~2025-10-24  6:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24  6:19 Dan Carpenter [this message]
2025-10-24 16:03 ` [bug report] accel/amdxdna: Support firmware debug buffer Lizhi Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPsadTBXunUSBByV@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lizhi.hou@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.