From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net-next 2/8] net: stmmac: simplify stmmac_get_version()
Date: Fri, 24 Oct 2025 12:10:33 +0100 [thread overview]
Message-ID: <aPteqZ57fWULRfNy@shell.armlinux.org.uk> (raw)
In-Reply-To: <81d5c1f2-e912-40de-a870-290b0cf054b3@lunn.ch>
On Thu, Oct 23, 2025 at 08:46:00PM +0200, Andrew Lunn wrote:
> On Thu, Oct 23, 2025 at 10:37:29AM +0100, Russell King (Oracle) wrote:
> > We can simplify stmmac_get_version() by pre-initialising the version
> > members to zero, detecting the MAC100 core and returning, otherwise
> > determining the version register offset separately from calling
> > stmmac_get_id() and stmmac_get_dev_id(). Do this.
> >
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Hi Andrew,
It seems I had a typo "verison" which should've been "version" in this
patch, which carried through patches 3 and 4. Are you happy for me to
retain your r-b with this typo fixed please?
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-10-24 11:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 9:36 [PATCH net-next 0/8] net: stmmac: hwif.c cleanups Russell King (Oracle)
2025-10-23 9:37 ` [PATCH net-next 1/8] net: stmmac: move version handling into own function Russell King (Oracle)
2025-10-23 18:44 ` Andrew Lunn
2025-10-23 9:37 ` [PATCH net-next 2/8] net: stmmac: simplify stmmac_get_version() Russell King (Oracle)
2025-10-23 18:46 ` Andrew Lunn
2025-10-24 11:10 ` Russell King (Oracle) [this message]
2025-10-24 11:54 ` Andrew Lunn
2025-10-23 9:37 ` [PATCH net-next 3/8] net: stmmac: consolidate version reading and validation Russell King (Oracle)
2025-10-23 18:48 ` Andrew Lunn
2025-10-23 9:37 ` [PATCH net-next 4/8] net: stmmac: move stmmac_get_*id() into stmmac_get_version() Russell King (Oracle)
2025-10-23 18:48 ` Andrew Lunn
2025-10-23 9:37 ` [PATCH net-next 5/8] net: stmmac: use FIELD_GET() for version register Russell King (Oracle)
2025-10-23 18:49 ` Andrew Lunn
2025-10-23 9:37 ` [PATCH net-next 6/8] net: stmmac: provide function to lookup hwif Russell King (Oracle)
2025-10-23 18:51 ` Andrew Lunn
2025-10-23 9:37 ` [PATCH net-next 7/8] net: stmmac: use != rather than ^ for comparing dev_id Russell King (Oracle)
2025-10-23 18:51 ` Andrew Lunn
2025-10-23 9:38 ` [PATCH net-next 8/8] net: stmmac: reorganise stmmac_hwif_init() Russell King (Oracle)
2025-10-23 18:52 ` Andrew Lunn
2025-10-24 6:44 ` [PATCH net-next 0/8] net: stmmac: hwif.c cleanups Maxime Chevallier
2025-10-24 10:48 ` Russell King (Oracle)
2025-10-24 10:53 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPteqZ57fWULRfNy@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.