From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4162CCF9E0 for ; Fri, 24 Oct 2025 17:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ao9S444lZiP2U5NBhucLSQH6SGHozb3Z0cqr/Ck3lZc=; b=AIrPePI9Rau4aHaFgjoo9O9KQw aiG0clv/mfBv5pT2Uhj9Km2XtdohdmaLE2z+UB3jk76LB7k4KRkgSGCwHQ+5WKBeM0sDdPmTvwwOt 7VmBkGYmuRWQCmvEprwFzSnqKJdGde2eXIuKRDaW9HG5NcdrnBdGNON4yS8C+3x8hpV/Vhp4dlm2Y M5D+98UlXSzQp5KChx2s5b6HqSOODvUKRH0RufH9cUC38uVF+ly2rDnS70nWwAQeUG1L+hmlH9FVG WBK3t/5W8JUrk+oJJHNSck0VgdOKMlCYF9HqBos0vxEZtindmosdlDs65+ZXm/HmlyGo2giF8JcKS Yi9qak3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vCL9a-0000000A3U7-0gqq; Fri, 24 Oct 2025 17:00:38 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vCL9Y-0000000A3Tz-3wbH for linux-arm-kernel@lists.infradead.org; Fri, 24 Oct 2025 17:00:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 33A99614B4; Fri, 24 Oct 2025 17:00:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F798C4CEF1; Fri, 24 Oct 2025 17:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761325235; bh=P30Amz6t4gClv82kJnXzJCEXNT49i1otAZuXWkHsM8w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NuOyzL52sbbNkLTISaUiZcxVPMMcvE6/aTHVBAKCncbKyPyCpaTJbaelkUrzmIvHW /IQIIQH7hbBF2AjPQD68Pt4oJ7flSwE7WTcAmsTRXwZtluGJBM1hUtep1EscNVEtGw DYRvG672/gLhggR5E6rPmBLHOgHJ0I7vmRWesKniWEjE7PYFofpc114Sqd9bHnYefw YRVO6uihtxFDs4fa/4bV22aIP/BWlz6ieB2svEgOX2KesQ1bU3NzQaHK9ECvbm/oa4 SFvLUUzabBni7gjMcjnMStoX+T31dDTY4yTdYVozPoXLDTCriC69BpwkCCFOXhlatN soVUdWoN86OOQ== Date: Fri, 24 Oct 2025 18:00:30 +0100 From: Simon Horman To: Steffen Trumtrar Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dinh Nguyen , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , Matthew Gerlach , kernel@pengutronix.de, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Teoh Ji Sheng Subject: Re: [PATCH v5 02/10] net: stmmac: Use interrupt mode INTM=1 for per channel irq Message-ID: References: <20251024-v6-12-topic-socfpga-agilex5-v5-0-4c4a51159eeb@pengutronix.de> <20251024-v6-12-topic-socfpga-agilex5-v5-2-4c4a51159eeb@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251024-v6-12-topic-socfpga-agilex5-v5-2-4c4a51159eeb@pengutronix.de> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 24, 2025 at 01:49:54PM +0200, Steffen Trumtrar wrote: ... > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c ... > @@ -746,6 +750,22 @@ int stmmac_get_platform_resources(struct platform_device *pdev, > if (stmmac_res->irq < 0) > return stmmac_res->irq; > > + /* For RX Channel */ > + for (i = 0; i < MTL_MAX_RX_QUEUES; i++) { > + sprintf(irq_name, "%s%d", "macirq_rx", i); > + stmmac_res->rx_irq[i] = platform_get_irq_byname(pdev, irq_name); > + if (stmmac_res->rx_irq[i] < 0) > + break; > + } > + > + /* For TX Channel */ > + for (i = 0; i < MTL_MAX_TX_QUEUES; i++) { > + sprintf(irq_name, "%s%d", "macirq_tx", i); > + stmmac_res->tx_irq[i] = platform_get_irq_byname(pdev, irq_name); > + if (stmmac_res->tx_irq[i] < 0) > + break; nit: The two lines above abbove to be indented a bit too much. > + } > + > /* On some platforms e.g. SPEAr the wake up irq differs from the mac irq > * The external wake up irq can be passed through the platform code > * named as "eth_wake_irq" ...