From: Jarkko Sakkinen <jarkko@kernel.org>
To: Jonathan McDowell <noodles@earth.li>
Cc: linux-integrity@vger.kernel.org, keyring@vger.kernel.org,
dpsmith@apertussolutions.com, ross.philipson@oracle.com,
Roberto Sassu <roberto.sassu@huawei.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Jarkko Sakkinen <jarkko.sakkinen@opinsys.com>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 01/10] tpm: Cap the number of PCR banks
Date: Fri, 24 Oct 2025 21:50:34 +0300 [thread overview]
Message-ID: <aPvKetjkUh-_f0yl@kernel.org> (raw)
In-Reply-To: <aPYg1N0TvrkG6AJI@earth.li>
On Mon, Oct 20, 2025 at 12:45:24PM +0100, Jonathan McDowell wrote:
> On Sat, Oct 18, 2025 at 02:17:16PM +0300, Jarkko Sakkinen wrote:
> > From: Jarkko Sakkinen <jarkko.sakkinen@opinsys.com>
> >
> > tpm2_get_pcr_allocation() does not cap any upper limit for the number of
> > banks. Cap the limit to four banks so that out of bounds values coming
> > from external I/O cause on only limited harm.
>
> Comment no longer matches code - we cap at 8. With the comment fixed:
>
> Reviewed-By: Jonathan McDowell <noodles@meta.com>
Oops, sorry I'll address that and add your tag! Thank you.
BR, Jarkko
next prev parent reply other threads:[~2025-10-24 18:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 11:17 [PATCH v6 00/10] Prepare TPM driver for Trenchboot Jarkko Sakkinen
2025-10-18 11:17 ` [PATCH v6 01/10] tpm: Cap the number of PCR banks Jarkko Sakkinen
2025-10-20 11:45 ` Jonathan McDowell
2025-10-24 18:50 ` Jarkko Sakkinen [this message]
2025-10-18 11:17 ` [PATCH v6 02/10] tpm: Use -EPERM as fallback error code in tpm_ret_to_err Jarkko Sakkinen
2025-10-18 11:17 ` [PATCH v6 03/10] KEYS: trusted: Fix memory leak in tpm2_load() Jarkko Sakkinen
2025-10-18 11:17 ` [PATCH v6 04/10] KEYS: trusted: Use tpm_ret_to_err() in trusted_tpm2 Jarkko Sakkinen
2025-10-18 11:17 ` [PATCH v6 05/10] tpm2-sessions: Remove 'attributes' from tpm_buf_append_auth Jarkko Sakkinen
2025-10-18 11:17 ` [PATCH v6 06/10] tpm2-sessions: Unmask tpm_buf_append_hmac_session() Jarkko Sakkinen
2025-10-18 11:17 ` [PATCH v6 07/10] KEYS: trusted: Open code tpm2_buf_append() Jarkko Sakkinen
2025-10-18 11:17 ` [PATCH v6 08/10] tpm-buf: unify TPM_BUF_BOUNDARY_ERROR and TPM_BUF_OVERFLOW Jarkko Sakkinen
2025-10-18 11:17 ` [PATCH v6 09/10] tpm-buf: Remove chip parameter from tpm_buf_append_handle Jarkko Sakkinen
2025-10-18 11:17 ` [PATCH v6 10/10] tpm-buf: Enable managed and stack allocations Jarkko Sakkinen
2025-10-20 9:04 ` Stefano Garzarella
2025-10-24 18:49 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPvKetjkUh-_f0yl@kernel.org \
--to=jarkko@kernel.org \
--cc=dpsmith@apertussolutions.com \
--cc=jarkko.sakkinen@opinsys.com \
--cc=jgg@ziepe.ca \
--cc=keyring@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noodles@earth.li \
--cc=peterhuewe@gmx.de \
--cc=roberto.sassu@huawei.com \
--cc=ross.philipson@oracle.com \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.