From: Alice Ryhl <aliceryhl@google.com>
To: Hang Shu <m18080292938@163.com>
Cc: ojeda@kernel.org, "Hang Shu" <hangshu847@gmail.com>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Yutaro Ohno" <yutaro.ono.418@gmail.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Borys Tyran" <borys.tyran@protonmail.com>,
"Charalampos Mitrodimas" <charmitro@posteo.net>,
"Daniel Sedlak" <daniel@sedlak.dev>,
"Tamir Duberstein" <tamird@gmail.com>,
"Matt Gilbride" <mattgilbride@google.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: correct documentation comment for rbtree cursor peek_next method
Date: Fri, 7 Nov 2025 09:17:23 +0000 [thread overview]
Message-ID: <aQ25Ix2V_8IMc_8y@google.com> (raw)
In-Reply-To: <20251107024720.369067-1-m18080292938@163.com>
On Fri, Nov 07, 2025 at 02:47:16AM +0000, Hang Shu wrote:
> From: Hang Shu <hangshu847@gmail.com>
>
> The peek_next method's doc comment incorrectly stated it accesses the
> "previous" node when it actually accesses the next node. This commit
> fixes the documentation to accurately reflect the method's behavior.
>
> Fixes: 98c14e40e07a ("rust: rbtree: add cursor")
> Signed-off-by: Hang Shu <hangshu847@gmail.com>
I shared a Reviewed-by tag for the first version, so please include it
in the commit message when sending a new version. That way, I don't have
to review the same code twice.
Also, this should say [PATCH v2] in the subject since it's version 2 of
this patch.
Alice
next prev parent reply other threads:[~2025-11-07 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 2:47 [PATCH] rust: correct documentation comment for rbtree cursor peek_next method Hang Shu
2025-11-07 9:17 ` Alice Ryhl [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-11-06 11:20 Hang Shu
2025-11-06 11:32 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQ25Ix2V_8IMc_8y@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=borys.tyran@protonmail.com \
--cc=charmitro@posteo.net \
--cc=dakr@kernel.org \
--cc=daniel@sedlak.dev \
--cc=gary@garyguo.net \
--cc=hangshu847@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=m18080292938@163.com \
--cc=mattgilbride@google.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
--cc=yutaro.ono.418@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.