From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Darshan Rathod <darshanrathod475@gmail.com>
Cc: James.Bottomley@hansenpartnership.com,
martin.petersen@oracle.com, linux-arm-kernel@lists.infradead.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi/arm: Clean up coding style violations
Date: Fri, 7 Nov 2025 12:38:48 +0000 [thread overview]
Message-ID: <aQ3oWITFc3F6Hwhu@shell.armlinux.org.uk> (raw)
In-Reply-To: <20251107123435.1434-1-darshanrathod475@gmail.com>
On Fri, Nov 07, 2025 at 12:34:34PM +0000, Darshan Rathod wrote:
> Addressed checkpatch warnings by separating assignment from a conditional
> statement and documenting the empty for loop. These updates improve code
> clarity and maintain style consistency.
>
> No functional change intended.
>
> Signed-off-by: Darshan Rathod <darshanrathod475@gmail.com>
Up to the SCSI maintainers, but this code pre-dates many of the coding
style updates, and I believe there is a general policy not to "fix"
old code for such things. It creates noise and additional churn.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-11-07 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 12:34 [PATCH] scsi/arm: Clean up coding style violations Darshan Rathod
2025-11-07 12:38 ` Russell King (Oracle) [this message]
2025-11-08 17:33 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQ3oWITFc3F6Hwhu@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=James.Bottomley@hansenpartnership.com \
--cc=darshanrathod475@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.