From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 270DACCF9EB for ; Tue, 28 Oct 2025 00:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ch/dSHGxUjejgbIRliFGcJe5eBRFVOjPKbNGUoYLJcc=; b=WEdpOq56XXknFbcC4qTCdfIT9P 0a+W6yM/y3bbjjKReKZbKJQqMWjfix3VwHQxcNDXpPh+I9eTPGl6ETag8hZBwaz64fP/jc62lccRc nCOA2pkIU7JRUoz7ajINMtcCwnLg93MFGPtVbI6Dd8gtqZgvfpir0zr+I6Osq+kN0YIjN/30BGNG1 Z3E/z9wHVq8LeEh7SQ545Mi1dUnlLRkXAThXlEFefOJ+sGcsvfAo+5Z2HG5RpTIAQ6hvPjI6CBBUv atBIlFQutQk8+HbF+fHOQpoakbxA3Ieg7bYgN16DFVJE2VwYaYQpz0uCdQx15QMiOOUVlsrK4SJKV rXLQZ1SQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDXi1-0000000Ezzi-2zgh; Tue, 28 Oct 2025 00:37:09 +0000 Received: from mail-pj1-x1049.google.com ([2607:f8b0:4864:20::1049]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDXhz-0000000EzxX-0VSR for kvm-riscv@lists.infradead.org; Tue, 28 Oct 2025 00:37:08 +0000 Received: by mail-pj1-x1049.google.com with SMTP id 98e67ed59e1d1-33dadf7c5beso4768950a91.0 for ; Mon, 27 Oct 2025 17:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761611825; x=1762216625; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=J3mxOKer4OGfyDxlfqvGDsZ/A3KYgtdet3LczK0ONqE=; b=x0J9Gv7No9QFvSn5UWnIJcTpz4HiL74KpiW9aD2Wxt0SncFIg2C97hW0RxJXqaJe1k RHo0dDok6A51buDGSwcoVuCXSuHR06i4y/devu6jOJ0tBD3IAVtJdWB8ZP33QZrq2BiA Yn88a/TeP/MwECU3EtwYMS3sfGRJaG1wgqu2iOYDJ3IIj0kJvZXSRCdfBz0t3ZofeFmy ZSf5NZ9jH7DpE0efEwEikKBan3W2ecq34yOplfeIQEPbQ8CTkllKqTIHc8G5yI/OjgvO RjS4ob9TfEKCdeqwWxKC79qzcDcAC/Hk3xKPnBgXMSmPpO8b5bB3X/X0Urmv7Ta8TMOF zYrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761611825; x=1762216625; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=J3mxOKer4OGfyDxlfqvGDsZ/A3KYgtdet3LczK0ONqE=; b=NWIDQ4bsezn9blZCkS7B1JRMQjdh/aoBH8/pEgVxwytuGc5fK0EwmWxupUEVloz+gB 4TsPKYSiKq/d4QjxNLUH4WqlREFS0x4HxBqZQVDL8WSK7zZ0XKGIHmng9wpQVu+IF1lE 3xX/vk9Sho19JKz4k6oWuYFe8T5ElTxxt0RfJsOVV1V2+oo5K2BM90bOkb+AV/uG3m9u Wop7zjoIjiQNNyyeRl7qM+sKvgvQ5GkiqAJDteixmIpUxIusvt6yWs9P84L9lxD7bVBs 1rnfYEWCo9HAAa7ZQEWt/JUCFNbyG+KOIAt98Ool39baaxqKBvk0/Ik08dyxGQpgtp7J szww== X-Forwarded-Encrypted: i=1; AJvYcCXlYsOURi3UTIMvAeT/v3tg0ADPPiuuY9PPFgQvL3vzcYgxyVojfNFZqyH0eZnkiruLuzEvtGSmfHQ=@lists.infradead.org X-Gm-Message-State: AOJu0YxU1Dt9SIfb7mkPsFPwB30wO0AAPu9Jf+jwHLY9oyW+wrheyjvn PKCWFjiFgI399mm2Tnb4lwzqjiyABBP4fIyij4BF9zRwZBog3JStWNhEQzDwgCO6ni5OL36SoTD d0FTA5A== X-Google-Smtp-Source: AGHT+IGoxyiEdJHjsguM4HhfYAa3a3WGl9IwGzua+OMwKu3+3dxnKcX9NeqRP2yYPcwFhiCcHGTefjSDvqI= X-Received: from pjcc13.prod.google.com ([2002:a17:90b:574d:b0:33d:813f:6829]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5241:b0:329:cb75:fef2 with SMTP id 98e67ed59e1d1-340279e5c84mr1590788a91.3.1761611825209; Mon, 27 Oct 2025 17:37:05 -0700 (PDT) Date: Mon, 27 Oct 2025 17:37:03 -0700 In-Reply-To: <55461c549803e08db97528127c29e092c597adc5.camel@intel.com> Mime-Version: 1.0 References: <20251017003244.186495-1-seanjc@google.com> <20251017003244.186495-25-seanjc@google.com> <55461c549803e08db97528127c29e092c597adc5.camel@intel.com> Message-ID: Subject: Re: [PATCH v3 24/25] KVM: TDX: Guard VM state transitions with "all" the locks From: Sean Christopherson To: Kai Huang Cc: "chenhuacai@kernel.org" , "frankja@linux.ibm.com" , "maz@kernel.org" , "borntraeger@linux.ibm.com" , "pjw@kernel.org" , "aou@eecs.berkeley.edu" , "kas@kernel.org" , "maobibo@loongson.cn" , "pbonzini@redhat.com" , "maddy@linux.ibm.com" , "palmer@dabbelt.com" , "imbrenda@linux.ibm.com" , "zhaotianrui@loongson.cn" , "anup@brainfault.org" , "oliver.upton@linux.dev" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , Yan Y Zhao , "michael.roth@amd.com" , "linux-kernel@vger.kernel.org" , Ira Weiny , "loongarch@lists.linux.dev" , "binbin.wu@linux.intel.com" , "ackerleytng@google.com" , "kvmarm@lists.linux.dev" , "kvm-riscv@lists.infradead.org" , Vishal Annapurve , "linuxppc-dev@lists.ozlabs.org" , Rick P Edgecombe , "linux-mips@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-riscv@lists.infradead.org" , "x86@kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251027_173707_156876_1839A2CA X-CRM114-Status: GOOD ( 17.79 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBPY3QgMjgsIDIwMjUsIEthaSBIdWFuZyB3cm90ZToKPiBPbiBUaHUsIDIwMjUtMTAt MTYgYXQgMTc6MzIgLTA3MDAsIFNlYW4gQ2hyaXN0b3BoZXJzb24gd3JvdGU6Cj4gPiBAQCAtMjc4 MSw4ICsyODI3LDYgQEAgaW50IHRkeF92bV9pb2N0bChzdHJ1Y3Qga3ZtICprdm0sIHZvaWQgX191 c2VyICphcmdwKQo+ID4gwqAJaWYgKHIpCj4gPiDCoAkJcmV0dXJuIHI7Cj4gPiDCoAo+ID4gLQln dWFyZChtdXRleCkoJmt2bS0+bG9jayk7Cj4gPiAtCj4gPiDCoAlzd2l0Y2ggKHRkeF9jbWQuaWQp IHsKPiA+IMKgCWNhc2UgS1ZNX1REWF9DQVBBQklMSVRJRVM6Cj4gPiDCoAkJciA9IHRkeF9nZXRf Y2FwYWJpbGl0aWVzKCZ0ZHhfY21kKTsKPiAKPiBJSVJDLCB0aGlzIHBhdGNoIHJlbW92ZXMgZ3Jh YmJpbmcgdGhlIGt2bS0+bG9jayBpbiB0ZHhfdm1faW9jdGwoKSBidXQgb25seQo+IGFkZHMgdGhl ICJiaWcgaGFtbWVyIiB0byB0ZHhfdGRfaW5pdCgpIGFuZCB0ZHhfdGRfZmluYWxpemUoKSwgc28g dGhlCj4gdGR4X2dldF9jYXBhYmlsaXRpZXMoKSBsb3N0IGhvbGRpbmcgdGhlIGt2bS0+bG9jay4K Ck9vaCwgeWVhaCwgbmljZSBjYXRjaCwgdGhhdCBpcyBpbmRlZWQgc2lsbHkgYW5kIHVubmVjZXNz YXJ5IGNodXJuLgoKPiBBcyByZXBsaWVkIGVhcmxpZXIsIEkgdGhpbmsgd2UgY2FuIGp1c3QgaG9s ZCB0aGUgImJpZyBoYW1tZXIiIGluCj4gdGR4X3ZtX2lvY3RsKCk/CgpBY3R1YWxseSwgSSB0aGlu ayB3ZSBjYW4gaGF2ZSBvdXIgY2FrZSBhbmQgZWF0IGl0IHRvby4gIFdpdGggdGhpcyBzbG90dGVk IGluIGFzCmEgcHJlcCBwYXRjaCwgdGhlIGJpZyBoYW1tZXIgY2FuIGxhbmQgZGlyZWN0bHkgaW4g dGR4X3ZtX2lvY3RsKCksIHdpdGhvdXQgYW55CmNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5IGZvciBL Vk1fVERYX0NBUEFCSUxJVElFUy4KCi0tCkZyb206IFNlYW4gQ2hyaXN0b3BoZXJzb24gPHNlYW5q Y0Bnb29nbGUuY29tPgpEYXRlOiBNb24sIDI3IE9jdCAyMDI1IDE3OjMyOjM0IC0wNzAwClN1Ympl Y3Q6IFtQQVRDSF0gS1ZNOiBURFg6IERvbid0IGNvcHkgImNtZCIgYmFjayB0byB1c2Vyc3BhY2Ug Zm9yCiBLVk1fVERYX0NBUEFCSUxJVElFUwoKRG9uJ3QgY29weSB0aGUga3ZtX3RkeF9jbWQgc3Ry dWN0dXJlIGJhY2sgdG8gdXNlcnNwYWNlIHdoZW4gaGFuZGxpbmcKS1ZNX1REWF9DQVBBQklMSVRJ RVMsIGFzIHRkeF9nZXRfY2FwYWJpbGl0aWVzKCkgZG9lc24ndCBtb2RpZnkgaHdfZXJyb3Igb3IK YW55IG90aGVyIGZpZWxkcy4KCk9wcG9ydHVuaXN0aWNhbGx5IGhvaXN0IHRoZSBjYWxsIHRvIHRk eF9nZXRfY2FwYWJpbGl0aWVzKCkgb3V0c2lkZSBvZiB0aGUKa3ZtLT5sb2NrIGNyaXRpY2FsIHNl Y3Rpb24sIGFzIGdldHRpbmcgdGhlIGNhcGFiaWxpdGllcyBkb2Vzbid0IHRvdWNoIHRoZQpWTSBp biBhbnkgd2F5LCBlLmcuIGRvZXNuJ3QgZXZlbiB0YWtlIEBrdm0uCgpTdWdnZXN0ZWQtYnk6IEth aSBIdWFuZyA8a2FpLmh1YW5nQGludGVsLmNvbT4KU2lnbmVkLW9mZi1ieTogU2VhbiBDaHJpc3Rv cGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+Ci0tLQogYXJjaC94ODYva3ZtL3ZteC90ZHguYyB8 IDYgKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2FyY2gveDg2L2t2bS92bXgvdGR4LmMgYi9hcmNoL3g4Ni9rdm0vdm14 L3RkeC5jCmluZGV4IDE2NDJkYTljMWZhOS4uNDNjMGMzZjZhOGMwIDEwMDY0NAotLS0gYS9hcmNo L3g4Ni9rdm0vdm14L3RkeC5jCisrKyBiL2FyY2gveDg2L2t2bS92bXgvdGR4LmMKQEAgLTI4MDcs MTIgKzI4MDcsMTIgQEAgaW50IHRkeF92bV9pb2N0bChzdHJ1Y3Qga3ZtICprdm0sIHZvaWQgX191 c2VyICphcmdwKQogCWlmIChyKQogCQlyZXR1cm4gcjsKIAorCWlmICh0ZHhfY21kLmlkID09IEtW TV9URFhfQ0FQQUJJTElUSUVTKQorCQlyZXR1cm4gdGR4X2dldF9jYXBhYmlsaXRpZXMoJnRkeF9j bWQpOworCiAJZ3VhcmQobXV0ZXgpKCZrdm0tPmxvY2spOwogCiAJc3dpdGNoICh0ZHhfY21kLmlk KSB7Ci0JY2FzZSBLVk1fVERYX0NBUEFCSUxJVElFUzoKLQkJciA9IHRkeF9nZXRfY2FwYWJpbGl0 aWVzKCZ0ZHhfY21kKTsKLQkJYnJlYWs7CiAJY2FzZSBLVk1fVERYX0lOSVRfVk06CiAJCXIgPSB0 ZHhfdGRfaW5pdChrdm0sICZ0ZHhfY21kKTsKIAkJYnJlYWs7CgpiYXNlLWNvbW1pdDogNjcyNTM3 MjMzYjhkYTJjMjlkY2E3MTU0YmYzYTMyMTFhZjdmNjEyOAotLQoKLS0gCmt2bS1yaXNjdiBtYWls aW5nIGxpc3QKa3ZtLXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rdm0tcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 044DD1F4606 for ; Tue, 28 Oct 2025 00:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761611827; cv=none; b=RaZ5Cq49HYht31n5I0LcPucPJv7FPYDhxoauzFUBOQf9abdkl9wFd0BFrY6DZIRhwgb5o/LJv1LP6aER1coyGJtiBzQavq764myE00xKJYc7LGXFgOcVH46VLN66nE6ASE4MCAAiZbB9PtEHXylWp94ma4/y8o37zMPyfAx1p+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761611827; c=relaxed/simple; bh=QdkEAMsGYBzU3fN0cne5qZg46IOFvPzz9xbD2HV7VAQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=D5Ty51yS1V3Vz+p6iC7VOrpnFRLFheV0/QMvnz1FNZ6fFlPei0G3F/NAgzxp+fuYzu2M3LkLR+fKSN69rGBSaqscocGoNS6yxDrDBQi1lYpySqtWzdPCxR2SRXIsn4t8kGfIWTnDDua5cvqn44dSHF5EiQL5xoqKxO1YOk0CW6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fgGyZuxZ; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fgGyZuxZ" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-33da21394adso5095045a91.1 for ; Mon, 27 Oct 2025 17:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761611825; x=1762216625; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=J3mxOKer4OGfyDxlfqvGDsZ/A3KYgtdet3LczK0ONqE=; b=fgGyZuxZxoFhZUStZEOkgSnMD24ZyWXS2V3OZAAoEIpZKU8UWL7ea7jebGj8oXRZvS ptJemZcBakmkJS9N0IfXOYbmFs227noHivg6R3O20yPkmSfN6CO3Z+ztmApH78+V4wmt 05pOWnwPEevb+e4h2Kj2Wd6JDa9GkI1IV2nTOjdHOibYwC0gFwibdcoXY05UV62Pw4Jt R0EnzB+vHuohh8eubyLliqqfKvzIt796M3KNC4/Nk9AWUG+hg0xldQGNUzvRsLXI1D5d xlbZ9Aet7yAYgIk9a05o0KkrC2b3Kd/i7/JMRWGgCcPAqXVm8r1nF3ed8R5ApIm/AU0E O50Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761611825; x=1762216625; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=J3mxOKer4OGfyDxlfqvGDsZ/A3KYgtdet3LczK0ONqE=; b=lIowBTUbN7kmdtp9PVFsu1MvuM2EZB9UXHXDMfzxfbOajackxov664nCy8Qh+r9ljj KH48zKvhVkDfVv/77qwlE/KfJxSL6dOHkbYgVXhHMwQhyNak+4UV6sJDstdVF9AzbU48 cRcSMsku3fj7MV3QnvVnva4AQGfPLLzJqojGiBxh/Tq4QUmm8Uf6pcSCrox3cAL7ygWV 6QIvQ6XAznO5dY/mCrBJpG9jMPoR9O9mkauoSmftEkBYEsz7o8oLnC2VT/XuDdVeG33t E0EdRFDUlOqenmWAJrYOzxd9SjcljYUEkb+tJf82DnqLkfYOBuRxSzLECuJPcqC7jtoA nTtg== X-Forwarded-Encrypted: i=1; AJvYcCXqKiLQ1MvX/1ThQ+xq2D8REYxEWyX7Ck2vu/WFaVdxcR4Qa1zt6C1wgLhrC7VxBj1W3Ms=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5JHsXjUsew8CR/P1YBG1Afi1FNeJe8AUvVln5dmyInDTN/esT vgv8q861GfbTne47OcW2NHyP8D072kzDStZ1EBgu8kMRZ6agibBcUWsMl54UgdSzgyCoZ7dJfQd /Y/4+0A== X-Google-Smtp-Source: AGHT+IGoxyiEdJHjsguM4HhfYAa3a3WGl9IwGzua+OMwKu3+3dxnKcX9NeqRP2yYPcwFhiCcHGTefjSDvqI= X-Received: from pjcc13.prod.google.com ([2002:a17:90b:574d:b0:33d:813f:6829]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5241:b0:329:cb75:fef2 with SMTP id 98e67ed59e1d1-340279e5c84mr1590788a91.3.1761611825209; Mon, 27 Oct 2025 17:37:05 -0700 (PDT) Date: Mon, 27 Oct 2025 17:37:03 -0700 In-Reply-To: <55461c549803e08db97528127c29e092c597adc5.camel@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251017003244.186495-1-seanjc@google.com> <20251017003244.186495-25-seanjc@google.com> <55461c549803e08db97528127c29e092c597adc5.camel@intel.com> Message-ID: Subject: Re: [PATCH v3 24/25] KVM: TDX: Guard VM state transitions with "all" the locks From: Sean Christopherson To: Kai Huang Cc: "chenhuacai@kernel.org" , "frankja@linux.ibm.com" , "maz@kernel.org" , "borntraeger@linux.ibm.com" , "pjw@kernel.org" , "aou@eecs.berkeley.edu" , "kas@kernel.org" , "maobibo@loongson.cn" , "pbonzini@redhat.com" , "maddy@linux.ibm.com" , "palmer@dabbelt.com" , "imbrenda@linux.ibm.com" , "zhaotianrui@loongson.cn" , "anup@brainfault.org" , "oliver.upton@linux.dev" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , Yan Y Zhao , "michael.roth@amd.com" , "linux-kernel@vger.kernel.org" , Ira Weiny , "loongarch@lists.linux.dev" , "binbin.wu@linux.intel.com" , "ackerleytng@google.com" , "kvmarm@lists.linux.dev" , "kvm-riscv@lists.infradead.org" , Vishal Annapurve , "linuxppc-dev@lists.ozlabs.org" , Rick P Edgecombe , "linux-mips@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-riscv@lists.infradead.org" , "x86@kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tue, Oct 28, 2025, Kai Huang wrote: > On Thu, 2025-10-16 at 17:32 -0700, Sean Christopherson wrote: > > @@ -2781,8 +2827,6 @@ int tdx_vm_ioctl(struct kvm *kvm, void __user *ar= gp) > > =C2=A0 if (r) > > =C2=A0 return r; > > =C2=A0 > > - guard(mutex)(&kvm->lock); > > - > > =C2=A0 switch (tdx_cmd.id) { > > =C2=A0 case KVM_TDX_CAPABILITIES: > > =C2=A0 r =3D tdx_get_capabilities(&tdx_cmd); >=20 > IIRC, this patch removes grabbing the kvm->lock in tdx_vm_ioctl() but onl= y > adds the "big hammer" to tdx_td_init() and tdx_td_finalize(), so the > tdx_get_capabilities() lost holding the kvm->lock. Ooh, yeah, nice catch, that is indeed silly and unnecessary churn. > As replied earlier, I think we can just hold the "big hammer" in > tdx_vm_ioctl()? Actually, I think we can have our cake and eat it too. With this slotted i= n as a prep patch, the big hammer can land directly in tdx_vm_ioctl(), without a= ny change in functionality for KVM_TDX_CAPABILITIES. -- From: Sean Christopherson Date: Mon, 27 Oct 2025 17:32:34 -0700 Subject: [PATCH] KVM: TDX: Don't copy "cmd" back to userspace for KVM_TDX_CAPABILITIES Don't copy the kvm_tdx_cmd structure back to userspace when handling KVM_TDX_CAPABILITIES, as tdx_get_capabilities() doesn't modify hw_error or any other fields. Opportunistically hoist the call to tdx_get_capabilities() outside of the kvm->lock critical section, as getting the capabilities doesn't touch the VM in any way, e.g. doesn't even take @kvm. Suggested-by: Kai Huang Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/tdx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c index 1642da9c1fa9..43c0c3f6a8c0 100644 --- a/arch/x86/kvm/vmx/tdx.c +++ b/arch/x86/kvm/vmx/tdx.c @@ -2807,12 +2807,12 @@ int tdx_vm_ioctl(struct kvm *kvm, void __user *argp= ) if (r) return r; =20 + if (tdx_cmd.id =3D=3D KVM_TDX_CAPABILITIES) + return tdx_get_capabilities(&tdx_cmd); + guard(mutex)(&kvm->lock); =20 switch (tdx_cmd.id) { - case KVM_TDX_CAPABILITIES: - r =3D tdx_get_capabilities(&tdx_cmd); - break; case KVM_TDX_INIT_VM: r =3D tdx_td_init(kvm, &tdx_cmd); break; base-commit: 672537233b8da2c29dca7154bf3a3211af7f6128 -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5CBFCCF9E5 for ; Tue, 28 Oct 2025 00:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ia8FJNTwlbQUhY7IFi3wCjccFlQchVXNojaNRvTGvTY=; b=dbwAyhgaSzarMyFXbevzUzU0vs jMROl4I74wcueJjQKUhsg00XNn9jYgj29erbeChehx8cNpHqQuCVVOdQVY5nCEJHHOPQw7Ep4N8SS mFo3mJ0/kCNlo2OgXCXa+QNHtDqqLQTy3tdITnPCsBWoOmBn25ftdM/C9+YHxtWUZ6YahixHqT3hr 7r1FxaSJqai86Aa1xzhBzL2sM3BeCHU9jTw/6Qc56gJ9MPzYHPW3BxxslUuIqxe+aqcQVzVXYHbsx tKujy9QEg30xobWXM/0+M5Zhy9rs9ntocSCTRrKn+kKR8Be7YyAMsnNmo608azYFNVAnodBfRTZxz cVLRCpSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDXi0-0000000Ezyf-2Tyz; Tue, 28 Oct 2025 00:37:08 +0000 Received: from mail-pj1-x104a.google.com ([2607:f8b0:4864:20::104a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDXhy-0000000EzxW-1qeE for linux-riscv@lists.infradead.org; Tue, 28 Oct 2025 00:37:07 +0000 Received: by mail-pj1-x104a.google.com with SMTP id 98e67ed59e1d1-33dadf7c5beso4768948a91.0 for ; Mon, 27 Oct 2025 17:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761611825; x=1762216625; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=J3mxOKer4OGfyDxlfqvGDsZ/A3KYgtdet3LczK0ONqE=; b=x0J9Gv7No9QFvSn5UWnIJcTpz4HiL74KpiW9aD2Wxt0SncFIg2C97hW0RxJXqaJe1k RHo0dDok6A51buDGSwcoVuCXSuHR06i4y/devu6jOJ0tBD3IAVtJdWB8ZP33QZrq2BiA Yn88a/TeP/MwECU3EtwYMS3sfGRJaG1wgqu2iOYDJ3IIj0kJvZXSRCdfBz0t3ZofeFmy ZSf5NZ9jH7DpE0efEwEikKBan3W2ecq34yOplfeIQEPbQ8CTkllKqTIHc8G5yI/OjgvO RjS4ob9TfEKCdeqwWxKC79qzcDcAC/Hk3xKPnBgXMSmPpO8b5bB3X/X0Urmv7Ta8TMOF zYrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761611825; x=1762216625; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=J3mxOKer4OGfyDxlfqvGDsZ/A3KYgtdet3LczK0ONqE=; b=jKM1S8BtqNqZPofk6d3ejnPLGbdrB+KoJ2R3+Pi41N+QfkQjaq1jgJKVErXVDGySlv RE3Sv0I78QrGu3h5ZdY3KhBvoi4+hm9OA0I9y6FGzFlH/8tp0gEvfeEm3sBizEC+2//R lggruEMC5nZIXgDBmosOfhxXdzSVUPGDkEItPnkmuUPnU0nMH1EyqbKheLIfl8pE0aPw kFiErJ1Q56w/AsB2zfwix8JxQCSg1iN5L51Xm2PtuYzIchhz7Gy+n/XoI4zemUp6T3ri zOB2uLBQaHFQEs2F/fqj9jGvkoUJeVUe5ic2+iaf9J7e03WfGA1vRhw492z8xickSS2R uISw== X-Forwarded-Encrypted: i=1; AJvYcCVAlvu/sXRwGMIXVgzDdW1aGonDC1pWPQnFwoWC8KyoIKQDS8Fo1cIQdaUP+Zl5faAMQvktViwAsC8aUw==@lists.infradead.org X-Gm-Message-State: AOJu0Yzd+oTk+zfwfZLdCGT43BibY6SJoRR4phFQukJbMx7dXvjrl76E 8wnnOojlq3RR0k5Z34Pnh41SsYrMH+kfu5bdD3iN+n+T6ql1hzNuOGni8Hyyh502jTTNFypVQm6 gBsRQBQ== X-Google-Smtp-Source: AGHT+IGoxyiEdJHjsguM4HhfYAa3a3WGl9IwGzua+OMwKu3+3dxnKcX9NeqRP2yYPcwFhiCcHGTefjSDvqI= X-Received: from pjcc13.prod.google.com ([2002:a17:90b:574d:b0:33d:813f:6829]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5241:b0:329:cb75:fef2 with SMTP id 98e67ed59e1d1-340279e5c84mr1590788a91.3.1761611825209; Mon, 27 Oct 2025 17:37:05 -0700 (PDT) Date: Mon, 27 Oct 2025 17:37:03 -0700 In-Reply-To: <55461c549803e08db97528127c29e092c597adc5.camel@intel.com> Mime-Version: 1.0 References: <20251017003244.186495-1-seanjc@google.com> <20251017003244.186495-25-seanjc@google.com> <55461c549803e08db97528127c29e092c597adc5.camel@intel.com> Message-ID: Subject: Re: [PATCH v3 24/25] KVM: TDX: Guard VM state transitions with "all" the locks From: Sean Christopherson To: Kai Huang Cc: "chenhuacai@kernel.org" , "frankja@linux.ibm.com" , "maz@kernel.org" , "borntraeger@linux.ibm.com" , "pjw@kernel.org" , "aou@eecs.berkeley.edu" , "kas@kernel.org" , "maobibo@loongson.cn" , "pbonzini@redhat.com" , "maddy@linux.ibm.com" , "palmer@dabbelt.com" , "imbrenda@linux.ibm.com" , "zhaotianrui@loongson.cn" , "anup@brainfault.org" , "oliver.upton@linux.dev" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , Yan Y Zhao , "michael.roth@amd.com" , "linux-kernel@vger.kernel.org" , Ira Weiny , "loongarch@lists.linux.dev" , "binbin.wu@linux.intel.com" , "ackerleytng@google.com" , "kvmarm@lists.linux.dev" , "kvm-riscv@lists.infradead.org" , Vishal Annapurve , "linuxppc-dev@lists.ozlabs.org" , Rick P Edgecombe , "linux-mips@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-riscv@lists.infradead.org" , "x86@kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251027_173706_485650_29573CF4 X-CRM114-Status: GOOD ( 17.79 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBPY3QgMjgsIDIwMjUsIEthaSBIdWFuZyB3cm90ZToKPiBPbiBUaHUsIDIwMjUtMTAt MTYgYXQgMTc6MzIgLTA3MDAsIFNlYW4gQ2hyaXN0b3BoZXJzb24gd3JvdGU6Cj4gPiBAQCAtMjc4 MSw4ICsyODI3LDYgQEAgaW50IHRkeF92bV9pb2N0bChzdHJ1Y3Qga3ZtICprdm0sIHZvaWQgX191 c2VyICphcmdwKQo+ID4gwqAJaWYgKHIpCj4gPiDCoAkJcmV0dXJuIHI7Cj4gPiDCoAo+ID4gLQln dWFyZChtdXRleCkoJmt2bS0+bG9jayk7Cj4gPiAtCj4gPiDCoAlzd2l0Y2ggKHRkeF9jbWQuaWQp IHsKPiA+IMKgCWNhc2UgS1ZNX1REWF9DQVBBQklMSVRJRVM6Cj4gPiDCoAkJciA9IHRkeF9nZXRf Y2FwYWJpbGl0aWVzKCZ0ZHhfY21kKTsKPiAKPiBJSVJDLCB0aGlzIHBhdGNoIHJlbW92ZXMgZ3Jh YmJpbmcgdGhlIGt2bS0+bG9jayBpbiB0ZHhfdm1faW9jdGwoKSBidXQgb25seQo+IGFkZHMgdGhl ICJiaWcgaGFtbWVyIiB0byB0ZHhfdGRfaW5pdCgpIGFuZCB0ZHhfdGRfZmluYWxpemUoKSwgc28g dGhlCj4gdGR4X2dldF9jYXBhYmlsaXRpZXMoKSBsb3N0IGhvbGRpbmcgdGhlIGt2bS0+bG9jay4K Ck9vaCwgeWVhaCwgbmljZSBjYXRjaCwgdGhhdCBpcyBpbmRlZWQgc2lsbHkgYW5kIHVubmVjZXNz YXJ5IGNodXJuLgoKPiBBcyByZXBsaWVkIGVhcmxpZXIsIEkgdGhpbmsgd2UgY2FuIGp1c3QgaG9s ZCB0aGUgImJpZyBoYW1tZXIiIGluCj4gdGR4X3ZtX2lvY3RsKCk/CgpBY3R1YWxseSwgSSB0aGlu ayB3ZSBjYW4gaGF2ZSBvdXIgY2FrZSBhbmQgZWF0IGl0IHRvby4gIFdpdGggdGhpcyBzbG90dGVk IGluIGFzCmEgcHJlcCBwYXRjaCwgdGhlIGJpZyBoYW1tZXIgY2FuIGxhbmQgZGlyZWN0bHkgaW4g dGR4X3ZtX2lvY3RsKCksIHdpdGhvdXQgYW55CmNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5IGZvciBL Vk1fVERYX0NBUEFCSUxJVElFUy4KCi0tCkZyb206IFNlYW4gQ2hyaXN0b3BoZXJzb24gPHNlYW5q Y0Bnb29nbGUuY29tPgpEYXRlOiBNb24sIDI3IE9jdCAyMDI1IDE3OjMyOjM0IC0wNzAwClN1Ympl Y3Q6IFtQQVRDSF0gS1ZNOiBURFg6IERvbid0IGNvcHkgImNtZCIgYmFjayB0byB1c2Vyc3BhY2Ug Zm9yCiBLVk1fVERYX0NBUEFCSUxJVElFUwoKRG9uJ3QgY29weSB0aGUga3ZtX3RkeF9jbWQgc3Ry dWN0dXJlIGJhY2sgdG8gdXNlcnNwYWNlIHdoZW4gaGFuZGxpbmcKS1ZNX1REWF9DQVBBQklMSVRJ RVMsIGFzIHRkeF9nZXRfY2FwYWJpbGl0aWVzKCkgZG9lc24ndCBtb2RpZnkgaHdfZXJyb3Igb3IK YW55IG90aGVyIGZpZWxkcy4KCk9wcG9ydHVuaXN0aWNhbGx5IGhvaXN0IHRoZSBjYWxsIHRvIHRk eF9nZXRfY2FwYWJpbGl0aWVzKCkgb3V0c2lkZSBvZiB0aGUKa3ZtLT5sb2NrIGNyaXRpY2FsIHNl Y3Rpb24sIGFzIGdldHRpbmcgdGhlIGNhcGFiaWxpdGllcyBkb2Vzbid0IHRvdWNoIHRoZQpWTSBp biBhbnkgd2F5LCBlLmcuIGRvZXNuJ3QgZXZlbiB0YWtlIEBrdm0uCgpTdWdnZXN0ZWQtYnk6IEth aSBIdWFuZyA8a2FpLmh1YW5nQGludGVsLmNvbT4KU2lnbmVkLW9mZi1ieTogU2VhbiBDaHJpc3Rv cGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+Ci0tLQogYXJjaC94ODYva3ZtL3ZteC90ZHguYyB8 IDYgKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2FyY2gveDg2L2t2bS92bXgvdGR4LmMgYi9hcmNoL3g4Ni9rdm0vdm14 L3RkeC5jCmluZGV4IDE2NDJkYTljMWZhOS4uNDNjMGMzZjZhOGMwIDEwMDY0NAotLS0gYS9hcmNo L3g4Ni9rdm0vdm14L3RkeC5jCisrKyBiL2FyY2gveDg2L2t2bS92bXgvdGR4LmMKQEAgLTI4MDcs MTIgKzI4MDcsMTIgQEAgaW50IHRkeF92bV9pb2N0bChzdHJ1Y3Qga3ZtICprdm0sIHZvaWQgX191 c2VyICphcmdwKQogCWlmIChyKQogCQlyZXR1cm4gcjsKIAorCWlmICh0ZHhfY21kLmlkID09IEtW TV9URFhfQ0FQQUJJTElUSUVTKQorCQlyZXR1cm4gdGR4X2dldF9jYXBhYmlsaXRpZXMoJnRkeF9j bWQpOworCiAJZ3VhcmQobXV0ZXgpKCZrdm0tPmxvY2spOwogCiAJc3dpdGNoICh0ZHhfY21kLmlk KSB7Ci0JY2FzZSBLVk1fVERYX0NBUEFCSUxJVElFUzoKLQkJciA9IHRkeF9nZXRfY2FwYWJpbGl0 aWVzKCZ0ZHhfY21kKTsKLQkJYnJlYWs7CiAJY2FzZSBLVk1fVERYX0lOSVRfVk06CiAJCXIgPSB0 ZHhfdGRfaW5pdChrdm0sICZ0ZHhfY21kKTsKIAkJYnJlYWs7CgpiYXNlLWNvbW1pdDogNjcyNTM3 MjMzYjhkYTJjMjlkY2E3MTU0YmYzYTMyMTFhZjdmNjEyOAotLQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0Cmxp bnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=