From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Angelo Dureghello" <adureghello@baylibre.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] iio: dac: ad3552r-hs: fix out-of-bound write in ad3552r_hs_write_data_source
Date: Tue, 28 Oct 2025 10:19:27 +0200 [thread overview]
Message-ID: <aQB8j7Hc3b9vAT5_@smile.fi.intel.com> (raw)
In-Reply-To: <aQB8PRlaBY_9-L8d@smile.fi.intel.com>
On Tue, Oct 28, 2025 at 10:18:05AM +0200, Andy Shevchenko wrote:
> On Mon, Oct 27, 2025 at 11:07:13PM +0800, Miaoqian Lin wrote:
...
> > + if (count >= sizeof(buf))
> > + return -ENOSPC;
>
> But this makes the validation too strict now.
>
> > ret = simple_write_to_buffer(buf, sizeof(buf) - 1, ppos, userbuf,
> > count);
>
> You definitely failed to read the code that implements the above.
>
> > if (ret < 0)
> > return ret;
> > - buf[count] = '\0';
> > + buf[ret] = '\0';
Maybe this line is what we might need, but I haven't checked deeper if it's a
problem.
> NAK.
>
> This patch is an unneeded churn.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-10-28 8:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 15:07 [PATCH] iio: dac: ad3552r-hs: fix out-of-bound write in ad3552r_hs_write_data_source Miaoqian Lin
2025-10-27 15:19 ` David Lechner
2025-10-27 16:05 ` Nuno Sá
2025-10-28 8:18 ` Andy Shevchenko
2025-10-28 8:19 ` Andy Shevchenko [this message]
2025-10-28 9:07 ` Andy Shevchenko
2025-10-28 9:46 ` 林妙倩
2025-10-28 9:58 ` Andy Shevchenko
2025-10-28 12:31 ` Nuno Sá
2025-10-28 14:45 ` Andy Shevchenko
2025-10-28 15:12 ` Nuno Sá
2025-10-28 15:19 ` Andy Shevchenko
2025-12-17 6:47 ` 林妙倩
2025-12-28 17:33 ` Andy Shevchenko
2025-10-28 11:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQB8j7Hc3b9vAT5_@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=adureghello@baylibre.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linmq006@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.