Re: [PATCH v6 bpf-next 16/17] selftests/bpf: add new verifier_gotox test

[Anton Protopopov <a.s.protopopov@gmail.com>]

On 25/10/27 04:11PM, Eduard Zingerman wrote:
> On Sun, 2025-10-26 at 12:34 +0000, Anton Protopopov wrote:
> > On 25/10/24 11:40AM, Anton Protopopov wrote:
> > > On 25/10/21 03:42PM, Eduard Zingerman wrote:
> > > > On Sun, 2025-10-19 at 20:21 +0000, Anton Protopopov wrote:
> > > > > Add a set of tests to validate core gotox functionality
> > > > > without need to rely on compilers.
> > > > > 
> > > > > Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
> > > > > ---
> > > > 
> > > > Thank you for adding these.
> > > > Could you please also add a test cases that checks the following errors:
> > > > - "jump table for insn %d points outside of the subprog [%u,%u]"
> 
> I'm surprised this one can't be triggered.
> In case if there are multiple subprograms defined,
> and map has two entries pointing to different subprograms,
> what other checks can catch this?
> I see only the check in the bpf_insn_array_init() that will make sure
> that offset does not point outside of the program.

Yes, you were correct. I will add a test.

> > > > - "the sum of R%u umin_value %llu and off %u is too big\n"
> 
> Ok, this one is handled by map value read.
> 
> > > > - "register R%d doesn't point to any offset in map id=%d\n"
> 
> And this one as well.
> 
> > > Yeah, sorry, these actually were on my list, but I've postponed them
> > > for the next version. Will add. (I also need to add a few selftests
> > > on the offset when loading from map.)
> > 
> > So, tbh, I can't actually find a way to trigger any of them,
> > looks like these conditions are always caught earlier...