From: Florian Westphal <fw@strlen.de>
To: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Cc: netfilter-devel@vger.kernel.org, jengelh@inai.de
Subject: Re: [PATCH 0/8] improve systemd service
Date: Tue, 28 Oct 2025 17:33:54 +0100 [thread overview]
Message-ID: <aQDwcsK0RKsrtVop@strlen.de> (raw)
In-Reply-To: <20251024023513.1000918-1-mail@christoph.anton.mitterer.name>
Christoph Anton Mitterer <mail@christoph.anton.mitterer.name> wrote:
[ CC Jan ]
> This is a first series of patches that tries to improve the included
> `nftables.service`.
Sir, this is netfilter-devel and not nftables-systemd-devel@.
> It contains the (hopefully) less controversial stuff I’d like to do. O:-)
>
> The main idea is to make things more hardened as it should be for loading
> firewall rules.
I have no horse in this race but I don't want to have too many changes
to this thing.
I see Jans original service file) as convinience / ease-of-use contribution
not as something that should be maintained continuously.
As for your series:
Its waaaay to many tiny patches. The first 4 patches could easily be
squashed into one without making it hard to review.
As for flush-on-shutdown: I see no need for that either. Jan?
FTR, this is about:
https://patchwork.ozlabs.org/series/479245/mbox/
next prev parent reply other threads:[~2025-10-28 16:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 2:08 [PATCH 0/8] improve systemd service Christoph Anton Mitterer
2025-10-24 2:08 ` [PATCH 1/9] tools: don’t set options whose values match their defaults Christoph Anton Mitterer
2025-10-24 2:08 ` [PATCH 2/9] tools: use the same pair of boolean literals Christoph Anton Mitterer
2025-10-24 2:08 ` [PATCH 3/9] tools: include further `Documentation=` URIs Christoph Anton Mitterer
2025-10-24 2:08 ` [PATCH 4/9] tools: reorder options Christoph Anton Mitterer
2025-10-28 17:15 ` Jan Engelhardt
2025-10-29 0:29 ` Christoph Anton Mitterer
2025-10-24 2:08 ` [PATCH 5/9] tools: depend on `sysinit.target` Christoph Anton Mitterer
2025-10-28 17:19 ` Jan Engelhardt
2025-10-29 0:35 ` Christoph Anton Mitterer
2025-10-24 2:08 ` [PATCH 6/9] tools: don’t stop `nftables.service` (and flush the ruleset) on shutdown Christoph Anton Mitterer
2025-10-24 2:08 ` [PATCH 7/9] tools: don’t stop `nftables.service` (and flush the ruleset) when isolating another unit Christoph Anton Mitterer
2025-10-24 2:08 ` [PATCH 8/9] tools: flush the ruleset only on an actual dedicated unit stop Christoph Anton Mitterer
2025-10-28 17:31 ` Jan Engelhardt
2025-10-28 17:37 ` Florian Westphal
2025-10-29 0:41 ` Christoph Anton Mitterer
2025-10-29 10:07 ` Jan Engelhardt
2025-10-30 0:53 ` Christoph Anton Mitterer
2025-10-30 23:34 ` Christoph Anton Mitterer
2025-10-24 2:08 ` [PATCH 9/9] tools: let the unit fail if the rules file is missing Christoph Anton Mitterer
2025-10-28 16:33 ` Florian Westphal [this message]
2025-10-29 0:27 ` [PATCH 0/8] improve systemd service Christoph Anton Mitterer
2025-10-29 11:40 ` Florian Westphal
2025-10-29 12:07 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQDwcsK0RKsrtVop@strlen.de \
--to=fw@strlen.de \
--cc=jengelh@inai.de \
--cc=mail@christoph.anton.mitterer.name \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.