From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] whitespace: correct bit assignment comments
Date: Wed, 29 Oct 2025 08:17:13 +0100 [thread overview]
Message-ID: <aQG_eRPmsxKqJ0H9@pks.im> (raw)
In-Reply-To: <xmqq8qgvdm0y.fsf_-_@gitster.g>
On Tue, Oct 28, 2025 at 09:33:01AM -0700, Junio C Hamano wrote:
> A comment in diff.c claimed that bits up to 12th (counting from 0th)
> are whitespace rules, and 13th thru 15th are for new/old/context,
> but it turns out it was miscounting. Correct them, and clarify
> where the whitespace rule bits come from in the comment. Extend bit
> assignment comments to cover bits used for color-moved, which
> weren't described.
>
> Also update the way these bit constants are defined to use (1 << N)
> notation, instead of octal constants, as it tends to make it easier
> to notice a breakage like this.
>
> Sprinkle a few blank lines between logically distinct groups of CPP
> macro definitions to make them easier to read.
Thanks, this version looks good to me!
Patrick
next prev parent reply other threads:[~2025-10-29 7:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 20:36 [PATCH] whitespace: correct bit assignment comments Junio C Hamano
2025-10-28 6:39 ` Patrick Steinhardt
2025-10-28 13:39 ` Junio C Hamano
2025-10-28 16:33 ` [PATCH v2] " Junio C Hamano
2025-10-29 7:17 ` Patrick Steinhardt [this message]
2025-10-29 13:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQG_eRPmsxKqJ0H9@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.