From: Harry Yoo <harry.yoo@oracle.com>
To: Petr Tesarik <ptesarik@suse.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] slab: convert setup_slub_debug() to use __core_param_cb()
Date: Wed, 29 Oct 2025 19:16:10 +0900 [thread overview]
Message-ID: <aQHpatjGesXvwMBj@hyeyoo> (raw)
In-Reply-To: <9674b34861394088c7853edf8e9d2b439fd4b42f.1761324765.git.ptesarik@suse.com>
On Fri, Oct 24, 2025 at 07:06:53PM +0200, Petr Tesarik wrote:
> Use __core_param_cb() to parse the "slab_debug" kernel parameter instead of
> the obsolescent __setup(). For now, the parameter is not exposed in sysfs,
> and no get ops is provided.
>
> There is a slight change in behavior. Before this patch, the following
> parameter would silently turn on full debugging for all slabs:
>
> slub_debug_yada_yada_gotta_love_this=hail_satan!
>
> This syntax is now rejected, and the parameter will be passed to user
> space, making the kernel a holier place.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> ---
Good byte to slub_debug_yada_yada_gotta_love_this=hail_satan! :'(
Looks good to me,
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
--
Cheers,
Harry / Hyeonggon
next prev parent reply other threads:[~2025-10-29 10:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 17:06 [PATCH 0/3] slab: switch away from the legacy param parser Petr Tesarik
2025-10-24 17:06 ` [PATCH 1/3] slab: constify slab debug strings Petr Tesarik
2025-10-24 17:44 ` Christoph Lameter (Ampere)
2025-10-29 9:54 ` Harry Yoo
2025-10-24 17:06 ` [PATCH 2/3] slab: convert setup_slub_debug() to use __core_param_cb() Petr Tesarik
2025-10-29 10:16 ` Harry Yoo [this message]
2025-10-24 17:06 ` [PATCH 3/3] slab: use new API for remaining command line parameters Petr Tesarik
2025-10-29 10:52 ` Harry Yoo
2025-10-30 13:32 ` Petr Tesarik
2025-10-30 13:35 ` Vlastimil Babka
2025-10-27 15:06 ` [PATCH 0/3] slab: switch away from the legacy param parser Vlastimil Babka
2025-10-30 11:36 ` Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQHpatjGesXvwMBj@hyeyoo \
--to=harry.yoo@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ptesarik@suse.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.