From: Zhao Liu <zhao1.liu@intel.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Ani Sinha <anisinha@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] tests/functional/x86_64/test_acpi_bits: Silence warnings reported by pylint
Date: Wed, 29 Oct 2025 23:41:58 +0800 [thread overview]
Message-ID: <aQI1xvVQfRBPVkgO@intel.com> (raw)
In-Reply-To: <20251029081514.60802-1-thuth@redhat.com>
On Wed, Oct 29, 2025 at 09:15:14AM +0100, Thomas Huth wrote:
> Date: Wed, 29 Oct 2025 09:15:14 +0100
> From: Thomas Huth <thuth@redhat.com>
> Subject: [PATCH] tests/functional/x86_64/test_acpi_bits: Silence warnings
> reported by pylint
>
> From: Thomas Huth <thuth@redhat.com>
>
> Pylint complains about too many positional arguments for the __init__
> function of the QEMUBitsMachine class, use a "*" to enforce argument
> passing by names instead (which the calling sites are doing here already).
>
> Second, use lazy logging when calling self.log.info() with a "%s" format
> string, and drop a superfluous "else:" that is not necessary after a
> "raise" statement.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/functional/x86_64/test_acpi_bits.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
LGTM,
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
prev parent reply other threads:[~2025-10-29 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 8:15 [PATCH] tests/functional/x86_64/test_acpi_bits: Silence warnings reported by pylint Thomas Huth
2025-10-29 15:41 ` Zhao Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQI1xvVQfRBPVkgO@intel.com \
--to=zhao1.liu@intel.com \
--cc=anisinha@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.