All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Harshita V Rajput <harshitha.vr@chelsio.com>
Cc: kuba@kernel.org, davem@davemloft.net, kernelxing@tencent.com,
	imx@lists.linux.dev, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, Potnuri Bharat Teja <bharat@chelsio.com>
Subject: Re: [PATCH] cxgb4: flower: add support for fragmentation
Date: Wed, 29 Oct 2025 16:05:40 +0000	[thread overview]
Message-ID: <aQI7VAXP3XMbYliQ@horms.kernel.org> (raw)
In-Reply-To: <20251028075255.1391596-1-harshitha.vr@chelsio.com>

On Tue, Oct 28, 2025 at 01:22:55PM +0530, Harshita V Rajput wrote:
> This patch adds support for matching fragmented packets in tc flower
> filters.
> 
> Previously, commit 93a8540aac72 ("cxgb4: flower: validate control flags")
> added a check using flow_rule_match_has_control_flags() to reject
> any rules with control flags, as the driver did not support
> fragmentation at that time.
> 
> Now, with this patch, support for FLOW_DIS_IS_FRAGMENT is added:
> - The driver checks for control flags using
>   flow_rule_is_supp_control_flags(), as recommended in
>   commit d11e63119432 ("flow_offload: add control flag checking helpers").
> - If the fragmentation flag is present, the driver sets `fs->val.frag` and
>   `fs->mask.frag` accordingly in the filter specification.
> 
> Since fragmentation is now supported, the earlier check that rejected all
> control flags (flow_rule_match_has_control_flags()) has been removed.
> 
> Signed-off-by: Harshita V Rajput <harshitha.vr@chelsio.com>
> Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>

Thanks for the comprehensive commit message.

Reviewed-by: Simon Horman <horms@kernel.org>

  reply	other threads:[~2025-10-29 16:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28  7:52 [PATCH] cxgb4: flower: add support for fragmentation Harshita V Rajput
2025-10-29 16:05 ` Simon Horman [this message]
2025-10-31  2:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQI7VAXP3XMbYliQ@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=bharat@chelsio.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=harshitha.vr@chelsio.com \
    --cc=imx@lists.linux.dev \
    --cc=kernelxing@tencent.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.