From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E82F23C513 for ; Wed, 29 Oct 2025 12:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.216.245.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761742060; cv=none; b=BDmGmnPSllTqxpPHEadpAnJa5J1qsptD84L8qPxbmEZFjKKeCrAXaDa3tp9bNHAjjibDauXZ3K0oTlPMGu2GaaxCfL0efaUAT5dvlEHsTUHQyzfGAl3UGDrsxDbBQ17IEN3RYuvdAKCIhmuFxWJd6eEED2aHwrGP7VJUPObJ9mA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761742060; c=relaxed/simple; bh=xT7WM98PqsnMe/rgryspXXrtcI7WDptXTvSKBTBORFo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ac0GNQe/wpWWnDZqnTT/DRykKR73Gr8Mol2o7Bljbx7bfF71OHRQbd2RXKrEbphIJfXhXga+U6d1E8MvW+SYE1SaZf7Aym0csDSY3MNTZlgDBdLKdZPcmWyYg3MQAHSbeLMjZpzp2oUue4Hphh8tngP4leaHURmv9L1As7mcUmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de; spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: by Chamillionaire.breakpoint.cc (Postfix, from userid 1003) id 2AA26602E2; Wed, 29 Oct 2025 13:47:36 +0100 (CET) Date: Wed, 29 Oct 2025 13:47:35 +0100 From: Florian Westphal To: Phil Sutter Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH 27/28] utils: Cover for missing newline after BUG() messages Message-ID: References: <20251023161417.13228-1-phil@nwl.cc> <20251023161417.13228-28-phil@nwl.cc> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251023161417.13228-28-phil@nwl.cc> Phil Sutter wrote: > Relieve callers from having to suffix their messages with a newline > escape sequence, have the macro append it to the format string instead. > > This is mostly a fix for (the many) calls to BUG() without a newline > suffix but causes an extra new line in (equally many) others. Fixing > them is subject to followup patch. Would you mind rebaseing this patch and the next one? No need to resend, just push these two out.