From: Peter Xu <peterx@redhat.com>
To: Juraj Marcin <jmarcin@redhat.com>
Cc: qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dave@treblig.org>,
Jiri Denemark <jdenemar@redhat.com>,
Fabiano Rosas <farosas@suse.de>
Subject: Re: [PATCH v2 4/4] migration: Introduce POSTCOPY_DEVICE state
Date: Wed, 29 Oct 2025 18:57:28 -0400 [thread overview]
Message-ID: <aQKb2BSvMBNKrbXZ@x1.local> (raw)
In-Reply-To: <20251027154115.4138677-5-jmarcin@redhat.com>
On Mon, Oct 27, 2025 at 04:41:11PM +0100, Juraj Marcin wrote:
[...]
> @@ -1752,6 +1756,7 @@ bool migration_in_postcopy(void)
> MigrationState *s = migrate_get_current();
>
> switch (s->state) {
> + case MIGRATION_STATUS_POSTCOPY_DEVICE:
> case MIGRATION_STATUS_POSTCOPY_ACTIVE:
> case MIGRATION_STATUS_POSTCOPY_PAUSED:
> case MIGRATION_STATUS_POSTCOPY_RECOVER_SETUP:
> @@ -1853,6 +1858,8 @@ int migrate_init(MigrationState *s, Error **errp)
> memset(&mig_stats, 0, sizeof(mig_stats));
> migration_reset_vfio_bytes_transferred();
>
> + s->postcopy_package_loaded = false;
Better reset postcopy_package_loaded_event (in case of continuous
postcopy-device failures)?
Other than that, looks all good, thanks!
Reviewed-by: Peter Xu <peterx@redhat.com>
> +
> return 0;
> }
--
Peter Xu
prev parent reply other threads:[~2025-10-29 22:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 15:41 [PATCH v2 0/4] migration: Introduce POSTCOPY_DEVICE state Juraj Marcin
2025-10-27 15:41 ` [PATCH v2 1/4] migration: Do not try to start VM if disk activation fails Juraj Marcin
2025-10-27 15:41 ` [PATCH v2 2/4] migration: Move postcopy_ram_listen_thread() to postcopy-ram.c Juraj Marcin
2025-10-29 19:53 ` Peter Xu
2025-10-30 13:08 ` Juraj Marcin
2025-10-30 15:16 ` Peter Xu
2025-10-27 15:41 ` [PATCH v2 3/4] migration: Refactor all incoming cleanup into migration_incoming_cleanup() Juraj Marcin
2025-10-29 22:02 ` Peter Xu
2025-10-27 15:41 ` [PATCH v2 4/4] migration: Introduce POSTCOPY_DEVICE state Juraj Marcin
2025-10-29 22:57 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQKb2BSvMBNKrbXZ@x1.local \
--to=peterx@redhat.com \
--cc=dave@treblig.org \
--cc=farosas@suse.de \
--cc=jdenemar@redhat.com \
--cc=jmarcin@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.