From: Florian Westphal <fw@strlen.de>
To: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft v6 0/3] doc: miscellaneous improvements
Date: Thu, 30 Oct 2025 11:34:17 +0100 [thread overview]
Message-ID: <aQM_Kc5sk7qmmKDP@strlen.de> (raw)
In-Reply-To: <80a6e18535c94b60a226c89b9de06070cd154214.camel@christoph.anton.mitterer.name>
Christoph Anton Mitterer <mail@christoph.anton.mitterer.name> wrote:
> On Wed, 2025-10-29 at 12:28 +0100, Florian Westphal wrote:
> >
> > What about this:
> > Thus, if any base chain uses drop as its policy, the same base
> > chain (or a
> > regular chain directly or indirectly called by it) must contain at
> > least one
> > *accept* rule to avoid all traffic from getting dropped.
>
> Isn't that still effectively the same?
?
> I mean the whole summary chapter explains things from the view of a
> single packet, as was also the case for my last version of this
> sentence:
> > + Thus, if any base chain uses drop as its policy, the same base chain (or any
> > + regular chain directly or indirectly called by it) must accept a packet or it
> > + is ensured to be ultimately dropped by it.
Whats that supposed to convey?
I will take your version (because I tire to iterate this again and again
but I think my version is better.
drop policy and no accept rule -> thats NOT what you want.
And thats what the 'all traffic' in my version intends to say.
> Your wording changes this now to refer to "all traffic", which I think
> make an unnecessary specialised case, namely that, where all packets
> would be dropped, unless there's at least one accept rule.
Isn't that a rather important point?
> The typical firewalling case is however that for most packets (that
> might end up on the system) there actually is no single rule that would
> accept them and only some of them get accept.
I would say most are accepted.
> > > IMO it doesn't make things easier for a beginner, if one basically
> > > has to read through everything to find all information.
> >
> > I added a reference. Also keep in mind that nftables will already
> > tell
> > you about terminal statement not at end.
> >
> > nft add rule ip f c drop counter
> > Error: Statement after terminal statement has no effect
>
> Sure. I know.
>
> Is it still mentioned somewhere that "comment" is an exception to the
> rule?
Its not an exception, comment is not a statement. Its isn't
executed/evaluated.
Its no different than
.... accept # do this
... except that "# do this" won't be sent to kernel and not included
when running 'list ruleset' and so on.
prev parent reply other threads:[~2025-10-30 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 14:54 [PATCH nft v6 0/3] doc: miscellaneous improvements Florian Westphal
2025-10-28 14:54 ` [PATCH nft v6 1/3] doc: add overall description of the ruleset evaluation Florian Westphal
2025-10-28 14:54 ` [PATCH nft v6 2/3] doc: fix/improve documentation of verdicts Florian Westphal
2025-10-28 14:54 ` [PATCH nft v6 3/3] doc: minor improvements the `reject` statement Florian Westphal
2025-10-29 0:19 ` [PATCH nft v6 0/3] doc: miscellaneous improvements Christoph Anton Mitterer
2025-10-29 11:28 ` Florian Westphal
2025-10-30 1:04 ` Christoph Anton Mitterer
2025-10-30 10:34 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQM_Kc5sk7qmmKDP@strlen.de \
--to=fw@strlen.de \
--cc=mail@christoph.anton.mitterer.name \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.