From: Florian Westphal <fw@strlen.de>
To: Alexandre Knecht <knecht.alexandre@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v2] parser_json: support handle for rule positioning in JSON add rule
Date: Thu, 30 Oct 2025 12:34:59 +0100 [thread overview]
Message-ID: <aQNNY-Flo9jFcay3@strlen.de> (raw)
In-Reply-To: <aQNBcGLaZTV8iRB1@strlen.de>
Florian Westphal <fw@strlen.de> wrote:
> Alexandre Knecht <knecht.alexandre@gmail.com> wrote:
> > This patch fixes JSON-based rule positioning when using "add rule" with
> > a handle parameter. Previously, the handle was deleted before being used
> > for positioning, causing rules to always be appended at the end of the
> > chain instead of being placed after the specified rule handle.
>
> LGTM, thanks for providing a new test for this.
Take that back, this patch breaks
tests/shell/testcases/json/0005secmark_objref_0
next prev parent reply other threads:[~2025-10-30 11:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 0:30 [nft PATCH] parser_json: support handle for rule positioning in JSON add rule Alexandre Knecht
2025-10-29 11:18 ` Florian Westphal
2025-10-29 22:45 ` Alexandre Knecht
2025-10-29 22:45 ` [nft PATCH v2] parser_json: support handle for rule positioning in JSON add rule Alexandre Knecht
2025-10-30 10:44 ` Florian Westphal
2025-10-30 11:34 ` Florian Westphal [this message]
2025-10-30 20:48 ` Alexandre Knecht
2025-11-02 12:41 ` Florian Westphal
2025-11-04 11:18 ` Phil Sutter
2025-11-06 8:40 ` Alexandre Knecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQNNY-Flo9jFcay3@strlen.de \
--to=fw@strlen.de \
--cc=knecht.alexandre@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.