From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE5AFCCF9F0 for ; Thu, 30 Oct 2025 23:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=wm78/yxe3YgqDWs1Gc1oKN1MzHYn+h65lYY8zzsvQGU=; b=fzCuLALDyn+0YlCF+H9MTxJbCN XFWspJXXTZDe04rKN5iELNUAXS1ned3w0BGGeU0fwXAuMsYibEehwxPtS+e89xPotgzlBr/ozAfXm mdzKsK+FIG0neuduOnR1G5KEKA6bkGsOtyvy+P57rZX6f6DmSF7qc6WrVopXRVu0OnrddP386ui7q g3S3eVaj7YH4hiwm2Z/1cZzbRMh/GDgdKfSFZYE+clCG3IGbBXIPsnEE481M5PFw55ikCdwhZ5CXg dl7PukvwlQOoJhOnQ2njqQcq/tvOKTej1S31snfH+7pNuoy3PjDm3VwSb/Vg9+xU+TJK1E97ceD9v qP2NCTzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vEcG6-000000059Kz-17Ye; Thu, 30 Oct 2025 23:40:46 +0000 Received: from mail-pf1-x449.google.com ([2607:f8b0:4864:20::449]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vEcG3-000000059Jl-2Q0w for kvm-riscv@lists.infradead.org; Thu, 30 Oct 2025 23:40:44 +0000 Received: by mail-pf1-x449.google.com with SMTP id d2e1a72fcca58-781171fe1c5so1554686b3a.0 for ; Thu, 30 Oct 2025 16:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761867642; x=1762472442; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=hANv7xEJBy7S5lh8h/UQF87h23G6mY0gbFBLav72O2Q=; b=aQHhujZNkrYlJ62Nx4qs5RFuV2+c+S17Gi53th1eADFUK4+m2/15JnSqXYN+IsNaly ixkGIKUM2fjJNVHw/28t76SMb7vYI1wJG5Rmh8q6E6JMVcD5hy9IsXpRdUBG+QKzgv8V amlE/i7veAGsAm3/Mhf+t+n7tdbuRY6AEoZu54AgYR7pOP4tilbaKjw352mU4nn/4tT5 iJ8qRxuS8zBszHyeno9PMDBHGIEQtA2jLKU5NEoQBjJ/tcdDXFHQU+LBlZEXQDzEdVGb 4jLgtftVm7wCCIUNM9gj6LhJ6Ew6lZBSipjKY//kOTsfmVBHbjH6ZxFzK64Y+3cMPUHG b2ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761867642; x=1762472442; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=hANv7xEJBy7S5lh8h/UQF87h23G6mY0gbFBLav72O2Q=; b=qtX9cVdqF7ppO5Qi383YEqKdn0H4qXCbFrn4dkvwMWYP9aSxXmOamQYPoqtUevZasD bsyYEEK9Wif794aq34TubritGkVNRjkEUb6V4B6cTU8SQ4g0PjvEzGvp7VRCM7n/qmrL bG5JcVSUG77TzedP/8uuVJ2JHNFIQ50O2ztp/p1M5UoA9/gRR8XWZCnX9Sxn1A1Egj/0 sBp+czGm8HOIcqF1fCC55kwIs1AqbMZwHvhNiFq9gMpo59/Lj78EYU5b2WfWa4Wfw35D pxoHuBKiIpSoQrY0OLYigKX4kw5NlOvIuzzZ1EQ1B6o9U/RpL/rSgBcnFaXnhwC4OHAk 92JQ== X-Forwarded-Encrypted: i=1; AJvYcCVHLo/H5PgTZ11uPybpe3mXa9lUEhUR08dersOIeZuHYtSFttMh3jiagryM17tn+p5GInp5nZwCAAw=@lists.infradead.org X-Gm-Message-State: AOJu0YyDnGG7v2satlXG+dbB7sW2+H9F2WvhEGVsuUTOX1TyJbckOJxK KutsRRoqgTyArK5b5cnoH+Lxnh78NNd6Z0KD2DFSYx3atRy8pWxYCMO1C1jX9dMgXqDMYZdNt8w qjOYAkQ== X-Google-Smtp-Source: AGHT+IH6kktSpJB8uW8dOccHej0bRJlF9t4mdGsOdXoLRdKSPbgGpCfMdKkfH5SPES5/Onbr9IfT7/Ky4i8= X-Received: from pfbhm7.prod.google.com ([2002:a05:6a00:6707:b0:77e:40c7:d12e]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3996:b0:7a4:460e:f86a with SMTP id d2e1a72fcca58-7a7796c8a99mr1645968b3a.25.1761867642073; Thu, 30 Oct 2025 16:40:42 -0700 (PDT) Date: Thu, 30 Oct 2025 16:40:40 -0700 In-Reply-To: <6572689b28a76bd95bc653b1fc1131fa57ed7669.camel@intel.com> Mime-Version: 1.0 References: <20251030200951.3402865-1-seanjc@google.com> <20251030200951.3402865-13-seanjc@google.com> <6572689b28a76bd95bc653b1fc1131fa57ed7669.camel@intel.com> Message-ID: Subject: Re: [PATCH v4 12/28] KVM: TDX: WARN if mirror SPTE doesn't have full RWX when creating S-EPT mapping From: Sean Christopherson To: Kai Huang Cc: "chenhuacai@kernel.org" , "frankja@linux.ibm.com" , "maz@kernel.org" , "borntraeger@linux.ibm.com" , "pjw@kernel.org" , "aou@eecs.berkeley.edu" , "kas@kernel.org" , "maobibo@loongson.cn" , "pbonzini@redhat.com" , "maddy@linux.ibm.com" , "palmer@dabbelt.com" , "imbrenda@linux.ibm.com" , "zhaotianrui@loongson.cn" , "anup@brainfault.org" , "oliver.upton@linux.dev" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , Yan Y Zhao , "michael.roth@amd.com" , "binbin.wu@linux.intel.com" , Ira Weiny , "loongarch@lists.linux.dev" , "ackerleytng@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "kvm-riscv@lists.infradead.org" , Vishal Annapurve , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , Rick P Edgecombe , "linux-riscv@lists.infradead.org" , "x86@kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251030_164043_619189_5C2903B2 X-CRM114-Status: GOOD ( 14.26 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBPY3QgMzAsIDIwMjUsIEthaSBIdWFuZyB3cm90ZToKPiBPbiBUaHUsIDIwMjUtMTAt MzAgYXQgMTM6MDkgLTA3MDAsIFNlYW4gQ2hyaXN0b3BoZXJzb24gd3JvdGU6Cj4gPiBQYXNzIGlu IHRoZSBtaXJyb3Jfc3B0ZSB0byBrdm1feDg2X29wcy5zZXRfZXh0ZXJuYWxfc3B0ZSgpIHRvIHBy b3ZpZGUKPiA+IHN5bW1ldHJ5IHdpdGggLnJlbW92ZV9leHRlcm5hbF9zcHRlKCksIGFuZCBhc3Nl cnQgaW4gVERYIHRoYXQgdGhlIG1pcnJvcgo+ID4gU1BURSBpcyBzaGFkb3ctcHJlc2VudCB3aXRo IGZ1bGwgUldYIHBlcm1pc3Npb25zICh0aGUgVERYLU1vZHVsZSBkb2Vzbid0Cj4gPiBhbGxvdyB0 aGUgaHlwZXJ2aXNvciB0byBjb250cm9sIHByb3RlY3Rpb25zKS4KPiA+IAo+ID4gU2lnbmVkLW9m Zi1ieTogU2VhbiBDaHJpc3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+Cj4gCj4gUmV2aWV3 ZWQtYnk6IEthaSBIdWFuZyA8a2FpLmh1YW5nQGludGVsLmNvbT4KPiAKPiBbLi4uXQo+IAo+ID4g IHN0YXRpYyBpbnQgdGR4X3NlcHRfc2V0X3ByaXZhdGVfc3B0ZShzdHJ1Y3Qga3ZtICprdm0sIGdm bl90IGdmbiwKPiA+IC0JCQkJICAgICBlbnVtIHBnX2xldmVsIGxldmVsLCBrdm1fcGZuX3QgcGZu KQo+ID4gKwkJCQkgICAgIGVudW0gcGdfbGV2ZWwgbGV2ZWwsIHU2NCBtaXJyb3Jfc3B0ZSkKPiA+ ICB7Cj4gPiAgCXN0cnVjdCBrdm1fdGR4ICprdm1fdGR4ID0gdG9fa3ZtX3RkeChrdm0pOwo+ID4g Kwlrdm1fcGZuX3QgcGZuID0gc3B0ZV90b19wZm4obWlycm9yX3NwdGUpOwo+ID4gIAo+ID4gIAkv KiBUT0RPOiBoYW5kbGUgbGFyZ2UgcGFnZXMuICovCj4gPiAgCWlmIChLVk1fQlVHX09OKGxldmVs ICE9IFBHX0xFVkVMXzRLLCBrdm0pKQo+ID4gIAkJcmV0dXJuIC1FSU87Cj4gPiAgCj4gPiArCVdB Uk5fT05fT05DRSghaXNfc2hhZG93X3ByZXNlbnRfcHRlKG1pcnJvcl9zcHRlKSB8fAo+ID4gKwkJ ICAgICAobWlycm9yX3NwdGUgJiBWTVhfRVBUX1JXWF9NQVNLKSAhPSBWTVhfRVBUX1JXWF9NQVNL KTsKPiA+ICsKPiAKPiBOaXQ6wqAKPiAKPiBJIGFtIGEgbGl0dGxlIGJpdCBjb25mdXNlZCBhYm91 dCB3aGVuIHRvIHVzZSBXQVJOX09OX09OQ0UoKSBhbmQKPiBLVk1fQlVHX09OKCkuIDotKQoKVmVy eSBsb29zZWx5OiBXQVJOIGlmIHRoZXJlJ3MgYSBkZWNlbnQgY2hhbmNlIGNhcnJ5aW5nIG9uIG1p Z2h0IGJlIGZpbmUsCktWTV9CVUdfT04oKSBpZiB0aGVyZSdzIGEgZ29vZCBjaGFuY2UgY2Fycnlp bmcgb24gd2lsbCBjcmFzaCB0aGUgaG9zdCBhbmQvb3IKY29ycnVwdCB0aGUgZ3Vlc3QsIGUuZy4g aWYgS1ZNIHN1c3BlY3RzIGEgaGFyZHdhcmUvVERYLU1vZHVsZSBpc3N1ZS4KCi0tIAprdm0tcmlz Y3YgbWFpbGluZyBsaXN0Cmt2bS1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va3ZtLXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7FB033E356 for ; Thu, 30 Oct 2025 23:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761867644; cv=none; b=TKs976ouyhAqGGSajzX/10ft+arZyn8awLSu+9NRArcmMxV/xiI5ujEWgnuSLF8wlyYDdAECrwF6M9EEPkxP8Z1VJ4plAda7IQ5FHL6fIcwGosCtGF5dB0Fc/Rjq8TsV0Osq6GEo0JmfanC35RxPB/0JVbX0neQwtKdGz8iBiyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761867644; c=relaxed/simple; bh=eUlRvGsTDsOghmrMBild//Vvtgn5Z9S+p8wIvknhN0Q=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=UbDllee8eVGyjY03obT+PQY6EqSs08HNpm3p4rHjxnVNbCAuPaKD7/eHhI5MN8G+7VZiLhJ8YZ+Jidn6OIxCOBp2JmdHf3ZYyyUrqbhBbc+rH3z+p6tB6SiH7or6kxCjqE2NIGVens8/kmfwkRLevJqVoUfbYi5vhxDUaEOiKz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=LNWX650V; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LNWX650V" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-792722e4ebeso1604388b3a.3 for ; Thu, 30 Oct 2025 16:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761867642; x=1762472442; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=hANv7xEJBy7S5lh8h/UQF87h23G6mY0gbFBLav72O2Q=; b=LNWX650VW7tHQNQnj4IWOW6VMCQLlPemGs7QajRKIzNpaKp0vl3fEWZcdp4Ls+MH74 tBfSq73CaaIgj+dNyGgZKtOtiacb2G5/40vQwjw+rmkhRFZ92QI4Jo5HuzuaQLp/CMGE B9IXAIyxgPcPCwaNoX7UMi6Sl9C8AXP/tlgaxoFJfgYrvout7QvNnliiBvx7NVq85Rcq R0cziLkrvm6GwOiC77h70HwpBMeLTW8loNJWZernZqoQDjXB6NmmqasFoJLz+SNAJESI 5l1TNl5dIQ/cUzczfTfM6SQL1kX5vVo8oEH33LpBmICpVHvaWyK77vzr2A9nl8HQ7heE faFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761867642; x=1762472442; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=hANv7xEJBy7S5lh8h/UQF87h23G6mY0gbFBLav72O2Q=; b=rmuzkR/QBle1y8fE1MpACUQlS+zE+lkRrR/cq8dXKFCRhpINBChnsMf9kmxYFCBZAn SV10419uTusdMMLtuguLHwS6jtSXXMRQkF6r9lGB+JPaKlmMNGdZ3DMftUOD1iTjzPXX IaS+OOYjx74S6l19nPkW6AJl7Lb7qa0mgiNCREGpzj240+6yLmbz7Os9FVvef236R/U+ RwlfjUTpS1MVbYTs7vS55iOllcwNcW0jxXmACAcs38dns9g3nt8tU+mGzxlZFJmzeNd/ /GfVHwfX7uWe0ecE1VaflqfmYaqNQ2RDGJR1LW7sXAH+Y4CAPMHzw5/cG4YDmkTDZRSP 0n9w== X-Forwarded-Encrypted: i=1; AJvYcCXeKJdv40viPuTSRwglIOpb9WBlPA9H+oJ09w43Viq1nrv5dVeHPVHOjt2SCWlYt/HWtJ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3DrgqWmdGcIwZczlONsKflXQaM7HFCg2Ow7cXEy2uT+V3wtu8 RSjuFajxvhzn7D+71b4IJ0AAxaT7dGZ2RNPO5Kregw3dQugRIXH9Pw6S2h/ODQPbVz/1pAD8isD i+YprdQ== X-Google-Smtp-Source: AGHT+IH6kktSpJB8uW8dOccHej0bRJlF9t4mdGsOdXoLRdKSPbgGpCfMdKkfH5SPES5/Onbr9IfT7/Ky4i8= X-Received: from pfbhm7.prod.google.com ([2002:a05:6a00:6707:b0:77e:40c7:d12e]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3996:b0:7a4:460e:f86a with SMTP id d2e1a72fcca58-7a7796c8a99mr1645968b3a.25.1761867642073; Thu, 30 Oct 2025 16:40:42 -0700 (PDT) Date: Thu, 30 Oct 2025 16:40:40 -0700 In-Reply-To: <6572689b28a76bd95bc653b1fc1131fa57ed7669.camel@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251030200951.3402865-1-seanjc@google.com> <20251030200951.3402865-13-seanjc@google.com> <6572689b28a76bd95bc653b1fc1131fa57ed7669.camel@intel.com> Message-ID: Subject: Re: [PATCH v4 12/28] KVM: TDX: WARN if mirror SPTE doesn't have full RWX when creating S-EPT mapping From: Sean Christopherson To: Kai Huang Cc: "chenhuacai@kernel.org" , "frankja@linux.ibm.com" , "maz@kernel.org" , "borntraeger@linux.ibm.com" , "pjw@kernel.org" , "aou@eecs.berkeley.edu" , "kas@kernel.org" , "maobibo@loongson.cn" , "pbonzini@redhat.com" , "maddy@linux.ibm.com" , "palmer@dabbelt.com" , "imbrenda@linux.ibm.com" , "zhaotianrui@loongson.cn" , "anup@brainfault.org" , "oliver.upton@linux.dev" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , Yan Y Zhao , "michael.roth@amd.com" , "binbin.wu@linux.intel.com" , Ira Weiny , "loongarch@lists.linux.dev" , "ackerleytng@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "kvm-riscv@lists.infradead.org" , Vishal Annapurve , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , Rick P Edgecombe , "linux-riscv@lists.infradead.org" , "x86@kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, Oct 30, 2025, Kai Huang wrote: > On Thu, 2025-10-30 at 13:09 -0700, Sean Christopherson wrote: > > Pass in the mirror_spte to kvm_x86_ops.set_external_spte() to provide > > symmetry with .remove_external_spte(), and assert in TDX that the mirro= r > > SPTE is shadow-present with full RWX permissions (the TDX-Module doesn'= t > > allow the hypervisor to control protections). > >=20 > > Signed-off-by: Sean Christopherson >=20 > Reviewed-by: Kai Huang >=20 > [...] >=20 > > static int tdx_sept_set_private_spte(struct kvm *kvm, gfn_t gfn, > > - enum pg_level level, kvm_pfn_t pfn) > > + enum pg_level level, u64 mirror_spte) > > { > > struct kvm_tdx *kvm_tdx =3D to_kvm_tdx(kvm); > > + kvm_pfn_t pfn =3D spte_to_pfn(mirror_spte); > > =20 > > /* TODO: handle large pages. */ > > if (KVM_BUG_ON(level !=3D PG_LEVEL_4K, kvm)) > > return -EIO; > > =20 > > + WARN_ON_ONCE(!is_shadow_present_pte(mirror_spte) || > > + (mirror_spte & VMX_EPT_RWX_MASK) !=3D VMX_EPT_RWX_MASK); > > + >=20 > Nit:=C2=A0 >=20 > I am a little bit confused about when to use WARN_ON_ONCE() and > KVM_BUG_ON(). :-) Very loosely: WARN if there's a decent chance carrying on might be fine, KVM_BUG_ON() if there's a good chance carrying on will crash the host and/o= r corrupt the guest, e.g. if KVM suspects a hardware/TDX-Module issue. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B4DDCCF9E3 for ; Thu, 30 Oct 2025 23:41:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=YDPq0DSV1ePSo0R3/Kfp0olSskM0WcltSd+M645mY1E=; b=ta/TcKhY/MIxw5J+iqLKY9jxC7 EDvl+epIstOoQlNHxtFpwia/Ucljt62jvVBRVw2Hek8/n38J6CI0QRxQT7n+HrjxNBqPsQKuS0fCw l4W3xYUYQmqkOrKnCwhaIk6chV7XYgH2CjbLXXnStbc2WZ9Imap3BOjHml0DbB86Ig5MQ+6gZkzW/ CLJOfafp5Pobdp831dNzkEEPj1s/ml5ra9wVItKKTBgpE4gyOb56YbKaXIzXshOWrGAfF07phwtey vPYl2DuV1iF688W0SgYrW1w4ngt3jKLr2uRitu21P5l+AlIjBo2h5X6tvCSYvgZad4OmjATMrYFMb 2eoyzFag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vEcG7-000000059LD-2y1T; Thu, 30 Oct 2025 23:40:47 +0000 Received: from mail-pf1-x449.google.com ([2607:f8b0:4864:20::449]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vEcG3-000000059Jm-44C7 for linux-riscv@lists.infradead.org; Thu, 30 Oct 2025 23:40:45 +0000 Received: by mail-pf1-x449.google.com with SMTP id d2e1a72fcca58-77f610f7325so1346090b3a.1 for ; Thu, 30 Oct 2025 16:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761867642; x=1762472442; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=hANv7xEJBy7S5lh8h/UQF87h23G6mY0gbFBLav72O2Q=; b=aQHhujZNkrYlJ62Nx4qs5RFuV2+c+S17Gi53th1eADFUK4+m2/15JnSqXYN+IsNaly ixkGIKUM2fjJNVHw/28t76SMb7vYI1wJG5Rmh8q6E6JMVcD5hy9IsXpRdUBG+QKzgv8V amlE/i7veAGsAm3/Mhf+t+n7tdbuRY6AEoZu54AgYR7pOP4tilbaKjw352mU4nn/4tT5 iJ8qRxuS8zBszHyeno9PMDBHGIEQtA2jLKU5NEoQBjJ/tcdDXFHQU+LBlZEXQDzEdVGb 4jLgtftVm7wCCIUNM9gj6LhJ6Ew6lZBSipjKY//kOTsfmVBHbjH6ZxFzK64Y+3cMPUHG b2ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761867642; x=1762472442; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=hANv7xEJBy7S5lh8h/UQF87h23G6mY0gbFBLav72O2Q=; b=OeWyRH6ed8k0i9pJFD8R+OnIp4HgDlKkQc30G1Zh2XdIppE6DeIHVGkLF4OpTf5IbT D7X+Zqu0uWGHLKlqgEu2DTePlp/a+OXb1WwdHuhOjGuP4fzpRtNVsuVWY4Bbht0NUa0O lbKJubUKgFhYh4FRI0GcApU6vU6bvs8lDbMzW41viGEriYeESjU0S1P8UGaM3xgd6Xdy KCPvIXDsez4xmd6sreVDqK+YclMfvWMDscKe82IIERn4P47nFWTtAYG8FlRw6nrvYIa2 bskBtqZUwHIJkARNvAEWUndwpfWiw9qYfYJ1fnOZ4R6XSPmEFnGEsinnJwQqCGo/VRxI V86g== X-Forwarded-Encrypted: i=1; AJvYcCUOS498p9e3bSBXr0k/skgwssaBfa6PLwE/8j6BvyRMyvq5iQTLRORmeUabHcoOYGaAgH8Mdm0GpdiZuQ==@lists.infradead.org X-Gm-Message-State: AOJu0YwV93NY1UCH7RaYdjOwDS5U1CqghbT3/qe04elbOtVxG31X8J0T 8kTUdekSGB6G5a0a+Tp/2hOWxc0IpXqs/d3xglaigs1TWuo0nefor3s3x+lMUsmBmZ/u17utB5b T7sDfnA== X-Google-Smtp-Source: AGHT+IH6kktSpJB8uW8dOccHej0bRJlF9t4mdGsOdXoLRdKSPbgGpCfMdKkfH5SPES5/Onbr9IfT7/Ky4i8= X-Received: from pfbhm7.prod.google.com ([2002:a05:6a00:6707:b0:77e:40c7:d12e]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3996:b0:7a4:460e:f86a with SMTP id d2e1a72fcca58-7a7796c8a99mr1645968b3a.25.1761867642073; Thu, 30 Oct 2025 16:40:42 -0700 (PDT) Date: Thu, 30 Oct 2025 16:40:40 -0700 In-Reply-To: <6572689b28a76bd95bc653b1fc1131fa57ed7669.camel@intel.com> Mime-Version: 1.0 References: <20251030200951.3402865-1-seanjc@google.com> <20251030200951.3402865-13-seanjc@google.com> <6572689b28a76bd95bc653b1fc1131fa57ed7669.camel@intel.com> Message-ID: Subject: Re: [PATCH v4 12/28] KVM: TDX: WARN if mirror SPTE doesn't have full RWX when creating S-EPT mapping From: Sean Christopherson To: Kai Huang Cc: "chenhuacai@kernel.org" , "frankja@linux.ibm.com" , "maz@kernel.org" , "borntraeger@linux.ibm.com" , "pjw@kernel.org" , "aou@eecs.berkeley.edu" , "kas@kernel.org" , "maobibo@loongson.cn" , "pbonzini@redhat.com" , "maddy@linux.ibm.com" , "palmer@dabbelt.com" , "imbrenda@linux.ibm.com" , "zhaotianrui@loongson.cn" , "anup@brainfault.org" , "oliver.upton@linux.dev" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , Yan Y Zhao , "michael.roth@amd.com" , "binbin.wu@linux.intel.com" , Ira Weiny , "loongarch@lists.linux.dev" , "ackerleytng@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "kvm-riscv@lists.infradead.org" , Vishal Annapurve , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , Rick P Edgecombe , "linux-riscv@lists.infradead.org" , "x86@kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251030_164044_116121_225E4C3A X-CRM114-Status: GOOD ( 14.26 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBPY3QgMzAsIDIwMjUsIEthaSBIdWFuZyB3cm90ZToKPiBPbiBUaHUsIDIwMjUtMTAt MzAgYXQgMTM6MDkgLTA3MDAsIFNlYW4gQ2hyaXN0b3BoZXJzb24gd3JvdGU6Cj4gPiBQYXNzIGlu IHRoZSBtaXJyb3Jfc3B0ZSB0byBrdm1feDg2X29wcy5zZXRfZXh0ZXJuYWxfc3B0ZSgpIHRvIHBy b3ZpZGUKPiA+IHN5bW1ldHJ5IHdpdGggLnJlbW92ZV9leHRlcm5hbF9zcHRlKCksIGFuZCBhc3Nl cnQgaW4gVERYIHRoYXQgdGhlIG1pcnJvcgo+ID4gU1BURSBpcyBzaGFkb3ctcHJlc2VudCB3aXRo IGZ1bGwgUldYIHBlcm1pc3Npb25zICh0aGUgVERYLU1vZHVsZSBkb2Vzbid0Cj4gPiBhbGxvdyB0 aGUgaHlwZXJ2aXNvciB0byBjb250cm9sIHByb3RlY3Rpb25zKS4KPiA+IAo+ID4gU2lnbmVkLW9m Zi1ieTogU2VhbiBDaHJpc3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+Cj4gCj4gUmV2aWV3 ZWQtYnk6IEthaSBIdWFuZyA8a2FpLmh1YW5nQGludGVsLmNvbT4KPiAKPiBbLi4uXQo+IAo+ID4g IHN0YXRpYyBpbnQgdGR4X3NlcHRfc2V0X3ByaXZhdGVfc3B0ZShzdHJ1Y3Qga3ZtICprdm0sIGdm bl90IGdmbiwKPiA+IC0JCQkJICAgICBlbnVtIHBnX2xldmVsIGxldmVsLCBrdm1fcGZuX3QgcGZu KQo+ID4gKwkJCQkgICAgIGVudW0gcGdfbGV2ZWwgbGV2ZWwsIHU2NCBtaXJyb3Jfc3B0ZSkKPiA+ ICB7Cj4gPiAgCXN0cnVjdCBrdm1fdGR4ICprdm1fdGR4ID0gdG9fa3ZtX3RkeChrdm0pOwo+ID4g Kwlrdm1fcGZuX3QgcGZuID0gc3B0ZV90b19wZm4obWlycm9yX3NwdGUpOwo+ID4gIAo+ID4gIAkv KiBUT0RPOiBoYW5kbGUgbGFyZ2UgcGFnZXMuICovCj4gPiAgCWlmIChLVk1fQlVHX09OKGxldmVs ICE9IFBHX0xFVkVMXzRLLCBrdm0pKQo+ID4gIAkJcmV0dXJuIC1FSU87Cj4gPiAgCj4gPiArCVdB Uk5fT05fT05DRSghaXNfc2hhZG93X3ByZXNlbnRfcHRlKG1pcnJvcl9zcHRlKSB8fAo+ID4gKwkJ ICAgICAobWlycm9yX3NwdGUgJiBWTVhfRVBUX1JXWF9NQVNLKSAhPSBWTVhfRVBUX1JXWF9NQVNL KTsKPiA+ICsKPiAKPiBOaXQ6wqAKPiAKPiBJIGFtIGEgbGl0dGxlIGJpdCBjb25mdXNlZCBhYm91 dCB3aGVuIHRvIHVzZSBXQVJOX09OX09OQ0UoKSBhbmQKPiBLVk1fQlVHX09OKCkuIDotKQoKVmVy eSBsb29zZWx5OiBXQVJOIGlmIHRoZXJlJ3MgYSBkZWNlbnQgY2hhbmNlIGNhcnJ5aW5nIG9uIG1p Z2h0IGJlIGZpbmUsCktWTV9CVUdfT04oKSBpZiB0aGVyZSdzIGEgZ29vZCBjaGFuY2UgY2Fycnlp bmcgb24gd2lsbCBjcmFzaCB0aGUgaG9zdCBhbmQvb3IKY29ycnVwdCB0aGUgZ3Vlc3QsIGUuZy4g aWYgS1ZNIHN1c3BlY3RzIGEgaGFyZHdhcmUvVERYLU1vZHVsZSBpc3N1ZS4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcg bGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK