All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Casey Chen <cachen@purestorage.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"yzhong@purestorage.com" <yzhong@purestorage.com>,
	"sconnor@purestorage.com" <sconnor@purestorage.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"mkhalfella@purestorage.com" <mkhalfella@purestorage.com>,
	Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH 1/1] nvme: fix use-after-free of admin queue via stale pointer
Date: Thu, 30 Oct 2025 20:54:34 -0600	[thread overview]
Message-ID: <aQQk6nWYeB71PBK_@kbusch-mbp> (raw)
In-Reply-To: <9669f8a9-11ad-4911-9e03-00758e1d9957@nvidia.com>

On Thu, Oct 30, 2025 at 08:12:53AM +0000, Chaitanya Kulkarni wrote:
> On 10/29/25 17:39, Keith Busch wrote:
> I've added required comments that are very much needed here,
> totally untested :-

Honestly that seems a bit verbose. The code mostly speaks for itself
with this move: the controller's request_queue reference remains active
as long as there's an active controller reference.

  reply	other threads:[~2025-10-31  2:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 21:08 [PATCH 0/1] cover letter Casey Chen
2025-10-29 21:08 ` [PATCH 1/1] nvme: fix use-after-free of admin queue via stale pointer Casey Chen
2025-10-29 23:00   ` Chaitanya Kulkarni
2025-10-29 23:33     ` Ming Lei
2025-10-30  0:39   ` Keith Busch
2025-10-30  8:12     ` Chaitanya Kulkarni
2025-10-31  2:54       ` Keith Busch [this message]
2025-10-31  8:16         ` Chaitanya Kulkarni
2025-10-31 19:19       ` Casey Chen
2025-10-31 19:31         ` Chaitanya Kulkarni
2025-11-04 22:39           ` Casey Chen
2025-11-04 23:00             ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQQk6nWYeB71PBK_@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=cachen@purestorage.com \
    --cc=chaitanyak@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=ming.lei@redhat.com \
    --cc=mkhalfella@purestorage.com \
    --cc=sconnor@purestorage.com \
    --cc=yzhong@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.