From: Patrick Steinhardt <ps@pks.im>
To: Xinyu Ruan via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Xinyu Ruan <r200981113@gmail.com>
Subject: Re: [PATCH] refs: add missing optimize implementation for debug ref backend
Date: Fri, 31 Oct 2025 07:39:07 +0100 [thread overview]
Message-ID: <aQRZizsobXECzvJI@pks.im> (raw)
In-Reply-To: <pull.2090.git.git.1761881859881.gitgitgadget@gmail.com>
On Fri, Oct 31, 2025 at 03:37:39AM +0000, Xinyu Ruan via GitGitGadget wrote:
> From: Xinyu Ruan <r200981113@gmail.com>
>
> The debug ref backend (refs_be_debug) was missing the optimize
> function pointer, which caused a segmentation fault when running
> 'GIT_TRACE_REFS=1 git pack-refs --all' command.
Thanks for sending the patch! As far as I can see though it's redundant
with Karthik's patch series that is currently cooking in 'seen' [1]. So
once that's merged down we should be good.
Patrick
[1]: <20251020-refs-code-cleanup-v2-1-f5349ed0f6a5@gmail.com>
prev parent reply other threads:[~2025-10-31 6:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 3:37 [PATCH] refs: add missing optimize implementation for debug ref backend Xinyu Ruan via GitGitGadget
2025-10-31 6:39 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQRZizsobXECzvJI@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=r200981113@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.