From: Michal Hocko <mhocko@suse.com>
To: Ankit Agrawal <ankita@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Aniket Agashe <aniketa@nvidia.com>,
Vikram Sethi <vsethi@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>, Matt Ochs <mochs@nvidia.com>,
Shameer Kolothum <skolothumtho@nvidia.com>,
"linmiaohe@huawei.com" <linmiaohe@huawei.com>,
"nao.horiguchi@gmail.com" <nao.horiguchi@gmail.com>,
"david@redhat.com" <david@redhat.com>,
"lorenzo.stoakes@oracle.com" <lorenzo.stoakes@oracle.com>,
"Liam.Howlett@oracle.com" <Liam.Howlett@oracle.com>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"rppt@kernel.org" <rppt@kernel.org>,
"surenb@google.com" <surenb@google.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"bp@alien8.de" <bp@alien8.de>,
"rafael@kernel.org" <rafael@kernel.org>,
"guohanjun@huawei.com" <guohanjun@huawei.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"kevin.tian@intel.com" <kevin.tian@intel.com>,
"alex@shazbot.org" <alex@shazbot.org>, Neo Jia <cjia@nvidia.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
"Tarun Gupta (SW-GPU)" <targupta@nvidia.com>,
Zhi Wang <zhiw@nvidia.com>, Dheeraj Nigam <dnigam@nvidia.com>,
Krishnakant Jaju <kjaju@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
"ira.weiny@intel.com" <ira.weiny@intel.com>,
"Smita.KoralahalliChannabasappa@amd.com"
<Smita.KoralahalliChannabasappa@amd.com>,
"u.kleine-koenig@baylibre.com" <u.kleine-koenig@baylibre.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] mm: handle poisoning of pfn without struct pages
Date: Fri, 31 Oct 2025 09:27:14 +0100 [thread overview]
Message-ID: <aQRy4rafpvo-W-j6@tiehlicka> (raw)
In-Reply-To: <MW4PR12MB7213976611F767842380FB56B0FAA@MW4PR12MB7213.namprd12.prod.outlook.com>
On Wed 29-10-25 03:15:08, Ankit Agrawal wrote:
> >> +static void add_to_kill_pfn(struct task_struct *tsk,
> >> + struct vm_area_struct *vma,
> >> + struct list_head *to_kill,
> >> + unsigned long pfn)
> >> +{
> >> + struct to_kill *tk;
> >> +
> >> + tk = kmalloc(sizeof(*tk), GFP_ATOMIC);
> >> + if (!tk)
> >> + return;
> >
> > This is unfortunate. GFP_ATOMIC is unreliable and we silently behave
> > as if it worked OK.
>
> Got it. I'll mark this as a failure case.
why do you need to batch all processes and kill them at once? Can you
just kill one by one?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2025-10-31 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 14:19 [PATCH v4 0/3] mm: Implement ECC handling for pfn with no struct page ankita
2025-10-26 14:19 ` [PATCH v4 1/3] mm: Change ghes code to allow poison of non-struct pfn ankita
2025-10-26 14:19 ` [PATCH v4 2/3] mm: handle poisoning of pfn without struct pages ankita
2025-10-28 0:26 ` Andrew Morton
2025-10-29 3:15 ` Ankit Agrawal
2025-10-31 8:27 ` Michal Hocko [this message]
2025-11-02 11:55 ` Ankit Agrawal
2025-11-03 18:22 ` Michal Hocko
2025-11-04 2:52 ` Andrew Morton
2025-11-04 10:37 ` Michal Hocko
2025-11-04 17:21 ` Ankit Agrawal
2025-10-26 14:19 ` [PATCH v4 3/3] vfio/nvgrace-gpu: register device memory for poison handling ankita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQRy4rafpvo-W-j6@tiehlicka \
--to=mhocko@suse.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Liam.Howlett@oracle.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex@shazbot.org \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=bp@alien8.de \
--cc=cjia@nvidia.com \
--cc=david@redhat.com \
--cc=dnigam@nvidia.com \
--cc=guohanjun@huawei.com \
--cc=ira.weiny@intel.com \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kjaju@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=lenb@kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mchehab@kernel.org \
--cc=mochs@nvidia.com \
--cc=nao.horiguchi@gmail.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=skolothumtho@nvidia.com \
--cc=surenb@google.com \
--cc=targupta@nvidia.com \
--cc=tony.luck@intel.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=vbabka@suse.cz \
--cc=vsethi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.